Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about R version support #295

Closed
IndrajeetPatil opened this issue Sep 5, 2022 · 7 comments · Fixed by #403
Closed

Add information about R version support #295

IndrajeetPatil opened this issue Sep 5, 2022 · 7 comments · Fixed by #403
Assignees

Comments

@IndrajeetPatil
Copy link
Member

Similar to:
https://www.tidyverse.org/blog/2019/04/r-version-support/

This should go into developer-facing vignette.

More importantly, we should test all supported R versions on GHA to ensure that we actually support these R versions. Currently, we don't do this. We support R >= 3.5, by test only until R >= 3.6 to avoid the headache of dealing with missing R packages on this older version.

P.S. TBH, given that R 3.6.0 was released almost 2.5 years ago (2019-04-26), I wouldn't mind bumping the minimum needed R version to 3.6.

@mattansb
Copy link
Member

mattansb commented Sep 5, 2022

How many major releases back should we support?

  • 4.2 current
  • 4.1
  • 4.0
  • 3.6
  • 3.5

So 3.6 doesn't feel that far back to me.

In effectsize I do test on 3.5 without a problem, using skip_if_not_installed() where needed (and I copied the yaml from you, so aren't everyone?)

@IndrajeetPatil
Copy link
Member Author

How many major releases back should we support?

You mean minor, right? (As in major.minor.patch).

I would say four; i.e., R >= 3.6.

@bwiernik
Copy link
Contributor

bwiernik commented Sep 6, 2022

Agree that 3.6 (two versions older than r-oldrel) is a good back-support line

@IndrajeetPatil
Copy link
Member Author

@strengejacke WDYT?

@strengejacke
Copy link
Member

Yeah, I agree. Back to 3.6 should be enough.

@strengejacke
Copy link
Member

Maybe we probably shouldn't make this change to insight, as some wider used packages that import insight still support R 3.5?

@IndrajeetPatil
Copy link
Member Author

See my response here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants