Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request/proposal: maintainers/authors optional infos in easybuild files #4401

Open
APN-Pucky opened this issue Dec 13, 2023 · 1 comment · May be fixed by #4460
Open

Feature request/proposal: maintainers/authors optional infos in easybuild files #4401

APN-Pucky opened this issue Dec 13, 2023 · 1 comment · May be fixed by #4460
Milestone

Comments

@APN-Pucky
Copy link
Contributor

APN-Pucky commented Dec 13, 2023

I saw several eb's where the first line comment was who created it. E.g.

I think that could also be helpful with directing issues to the original creator if they arise and later the eb's could be credited in repology (cf. repology/repology-updater#705 #4152).
I saw something like that mentioned in https://hackmd.io/tZtz6vMmRfGL6N9Rf__OEA#2023-11-13-sprint-1000-CET.

I'd suggest something like the pyproject.toml standard

authors = ["Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>"]

allowing for multiple maintainers and optionally their email.

@APN-Pucky APN-Pucky changed the title Feature request: maintainer/author optional infos in easybuild files Feature request/proposal: maintainer/author optional infos in easybuild files Dec 13, 2023
@APN-Pucky APN-Pucky changed the title Feature request/proposal: maintainer/author optional infos in easybuild files Feature request/proposal: maintainers/authors optional infos in easybuild files Dec 13, 2023
@boegel boegel added this to the 4.x milestone Dec 20, 2023
@Micket
Copy link
Contributor

Micket commented Mar 25, 2024

So, to be clear I'm definitely not speaking with any special authority, but I really hope we don't start doing this in the easyconfigs repo.

I do wish people would stop adding those comments, and I wish instead everyone just did nothing.
Fortunately, i think all maintainers and most frequent contributors all always ignore those contribution-comments completely and never add ourselves. Otherwise the comment fields would be insane (and so would an author list of everyone whoever bumped a version)

One-off easyconfigs like we have aren't really "maintained" by anyone.
Most contributions the author is less of a maintainer and more of a "whoever-last-decided-to-update-the-version-number-string-and-submit-a-pr".
I certainly do not want questions from the several hundreds easyconfigs I've made/updated directed to me.
If a question actually does arise where one needs into why something was done a certain way, one should not look at some author list of anyone who ever touched the version string, or even who touched it last, but the PR it stemmed from, who reviewed and merged that, a git blame. Maybe. It's not like that person has taken up the mantle of maintainer.

We do push for credits on patches and easyblocks, where there certainly is more choices made, and, of course, there is the git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants