CFITSIO sanity check not --module-only compatible

[akesandgren]

The sanity_check_command for CFITSIO is not --module-only compatible.

sanity_check_commands = [
    ('cd %(installdir)s/share && testprog'),
]

The above requires write access to %(installdir)s/share, which you may not have when running --module-only

Something like this will work better

sanity_check_commands = [
    ('cp %(installdir)s/share/testprog.tpt $TMPDIR && cd $TMPDIR && testprog'),
]

[lexming]

As discussed, testprog should be executed in the test phase. This does not look like a sanity check.

[boegel]

As discussed, testprog should be executed in the test phase. This does not look like a sanity check.

We can also run testprog in the test step, but this is an OK sanity check imho (assuming it's quick).

To answer's @akesandgren's question in Slack: EasyBuild sets $TMPDIR early on to a unique directory, so using this should be fine.

[lexming]

IMO a sanity check should be a single simple command. Copying files or changing dirs should not be done in it.

[jfgrimm]

IMO a sanity check should be a single simple command. Copying files or changing dirs should not be done in it.

What about software where e.g. additional compilation is done in the install step? Introduce a new post_install_test step?

[smoors]

What about software where e.g. additional compilation is done in the install step? Introduce a new post_install_test step?

EB already has support for an optional test_cases_step, see e.g. the nwchem easyblock.

[boegel]

IMO a sanity check should be a single simple command. Copying files or changing dirs should not be done in it.

I respectfully disagree. There's a lot of value in --sanity-check-only that can be used to check on an existing installation, without making any changes to it. It should definitely be quick and lightweight, but copying a file or doing a small compilation (see OpenMPI) is perfectly fine imho.