Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a default buildtype in MesonNinja easyblock #3280

Open
jfgrimm opened this issue Apr 5, 2024 · 2 comments
Open

set a default buildtype in MesonNinja easyblock #3280

jfgrimm opened this issue Apr 5, 2024 · 2 comments
Labels
EasyBuild-5.0 EasyBuild 5.0
Milestone

Comments

@jfgrimm
Copy link
Member

jfgrimm commented Apr 5, 2024

for e.g. CMake we add -DCMAKE_BUILD_TYPE=Release by default.
We don't currently do anything like that for meson: https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/generic/mesonninja.py#L95

this means we actually default to debug without optimisations (ref):

Option Default value Description Is per machine Is per subproject
buildtype {plain, debug, debugoptimized, release, minsize, custom} debug Build type to use no no

these options correspond to (ref):

buildtype debug optimization
plain false plain
debug true 0
debugoptimized true 2
release false 3
minsize true s
@jfgrimm jfgrimm added this to the 5.0 milestone Apr 5, 2024
@jfgrimm jfgrimm added the EasyBuild-5.0 EasyBuild 5.0 label Apr 5, 2024
@Micket
Copy link
Contributor

Micket commented Apr 5, 2024

I wonder if CFLAGS are saving us here anyway? Of course we should still set this, but we might not be as bad as it seems in general :) I do hope it picks up -march flags in general as well, otherwise it would still be bad.
We do normally just go with -O2 with easybuild though, but i suspect differences are minimal.

Semi related: #3032 (comment)

@jfgrimm
Copy link
Member Author

jfgrimm commented Apr 5, 2024

@Micket yes, it probably does. Better to be explicit though, rather than relying on what has priority internally in meson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EasyBuild-5.0 EasyBuild 5.0
Projects
None yet
Development

No branches or pull requests

2 participants