You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Tarball EasyBlock defines two extra_optionsinstall_type and preinstall_cmd. Besides a log message in run, the only place both are used is in the install_step.
So far it is perfectly fine. However, the BinariesTarball inherits the extra_options but overrides the install_step. Thus, the extra_options inherited from Tarball does nothing when used with BinariesTarball.
This behaviour was confusing to me as that is not what is stated in the documentation.
I see two possible solutions:
Rewrite the easyblocks such that BinariesTarball uses the extra_options.
2 .Override extra_options in BinariesTarball to remove unused extra_options.
As I found this issue when I was trying use preinstall_cmd I would prefer 1. If you agree that this is a bug I could probably write up a PR.
The text was updated successfully, but these errors were encountered:
would be good to reorganize Tarball a bit into so that the logic around install_type and preinstall_cmd doesn't have to be duplicated in BinariesTarball
The Tarball EasyBlock defines two extra_options
install_type
andpreinstall_cmd
. Besides a log message in run, the only place both are used is in theinstall_step
.So far it is perfectly fine. However, the BinariesTarball inherits the
extra_options
but overrides the install_step. Thus, the extra_options inherited from Tarball does nothing when used with BinariesTarball.This behaviour was confusing to me as that is not what is stated in the documentation.
I see two possible solutions:
2 .Override extra_options in BinariesTarball to remove unused extra_options.
As I found this issue when I was trying use
preinstall_cmd
I would prefer 1. If you agree that this is a bug I could probably write up a PR.The text was updated successfully, but these errors were encountered: