Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Flag for disabling Earthly internal labels #4069

Open
3manuek opened this issue Apr 30, 2024 · 2 comments
Open

proposal: Flag for disabling Earthly internal labels #4069

3manuek opened this issue Apr 30, 2024 · 2 comments
Labels
type:proposal A proposal for a new feature

Comments

@3manuek
Copy link
Contributor

3manuek commented Apr 30, 2024

Use case

Right now, Earthly includes a set of labels at SAVE IMAGE that are not related to the build itself:

    labels := map[string]string{
        "dev.earthly.version":  version.Version,
        "dev.earthly.git-sha":  version.GitSha,
        "dev.earthly.built-by": version.BuiltBy,
    }

Code

A flag like SAVE IMAGE --disable-earthly-labels might work. Also, a feature flag might need to be added.

Expected Behavior

It is expected that the user can control whether these labels are added or not to the produced image.

@3manuek 3manuek added the type:proposal A proposal for a new feature label Apr 30, 2024
@alexcb
Copy link
Collaborator

alexcb commented Apr 30, 2024

2721c63 is a good example which shows what's needed to introduce a new feature flag.

@3manuek
Copy link
Contributor Author

3manuek commented May 2, 2024

I started the patch at #4084. I don't see how to make the version feature to work even tho I added it, probably I'm missing some compilation flag cc @alexcb .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:proposal A proposal for a new feature
Projects
Status: No status
Development

No branches or pull requests

2 participants