Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ACL should not allow duplicate ACE entries in sequence #5138

Open
adamretter opened this issue Nov 22, 2023 · 0 comments
Open

[BUG] ACL should not allow duplicate ACE entries in sequence #5138

adamretter opened this issue Nov 22, 2023 · 0 comments
Assignees
Labels
bug issue confirmed as bug
Milestone

Comments

@adamretter
Copy link
Member

adamretter commented Nov 22, 2023

At the moment it seems it is possible to add the same ACE to the ACL in the same sequence.
It is possible to create the following ACL at the moment:

image

Because these entries are in sequence and are identical, then should only appear once. That is to say that when adding a new entry to the ACL, if it is the same as the previous entry, then doing so should be a no-op that returns a success result.


We likely need to add a check in the functions that implement ACLPermission#addACE(...). See:

  1. exist-core/src/main/java/org/exist/security/ACLPermission.java
  2. exist-core/src/main/java/org/exist/security/SimpleACLPermission.java
  3. exist-core/src/main/java/org/exist/security/internal/aider/SimpleACLPermissionAider.java
@adamretter adamretter added the bug issue confirmed as bug label Nov 22, 2023
@adamretter adamretter added this to the eXist-6.2.1 milestone Nov 22, 2023
@adamretter adamretter assigned adamretter and marmoure and unassigned adamretter Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue confirmed as bug
Projects
None yet
Development

No branches or pull requests

2 participants