Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Windows wallpaper #684

Closed
Davido264 opened this issue Aug 2, 2022 · 1 comment · Fixed by robwaz/pywal#1 · May be fixed by #708
Closed

Windows wallpaper #684

Davido264 opened this issue Aug 2, 2022 · 1 comment · Fixed by robwaz/pywal#1 · May be fixed by #708

Comments

@Davido264
Copy link

Hi there, I was working with the pywal module to make a plugin for another app, and i found that (at least in my pc) SystemParametersInfoA doesn't work, but SystemParametersInfoW does. My pc es 64 bit architecture, and acording to the logic in pywal.wallpaper.set_win_wallpaper(), SystemParametersInfoA should work. I'm not confident enough to make a pull request deleting that if statement (although it is simple lol).
I think I am doing something wrong or is an isolated case, so I mainly invite to research over this case

@Gremious
Copy link

The issue was not that you're supposed to use SystemParametersInfoW, it was that SystemParametersInfoA was passed the image path string in the wrong format :)

(In fact, as far as I saw, SystemParametersInfoA supposedly just re-encodes the string and calls SystemParametersInfoW?)

I have opened a PR which fixed the issue for me on Win 11: #708

robwaz added a commit to robwaz/pywal that referenced this issue Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants