Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading music with slow connection times out after 10 seconds #341

Open
SnipeXandrej opened this issue Mar 5, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@SnipeXandrej
Copy link

SnipeXandrej commented Mar 5, 2024

When I have poor internet connection and I try to download some music, the downloading will stop after 10 seconds. When the download stops, this error/warning appears in the terminal: context deadline exceeded (Client.Timeout or context cancellation while reading body).

Perhaps this commit that introduces a 10 second connection timeout is unintentionally interrupting any download that takes more than 10 seconds? eab7842

@dweymouth dweymouth added the bug Something isn't working label Mar 5, 2024
@dweymouth
Copy link
Owner

Yes you are right - the 10 second timeout will be problematic for downloads. However, removing it everywhere would mean the app would never give up waiting for a response from the server for other endpoints. I probably have to use a new HTTP client with no timeout just for the download API call.

@dweymouth dweymouth added this to the 0.10.0 milestone Mar 6, 2024
@dweymouth dweymouth removed this from the 0.10.0 milestone Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants