Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add free disk space startup check #351

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cravl-dev
Copy link
Contributor

Closes #331 by adding a startup check for at least 5GB of free space in ${HOME}.

@dw-0
Copy link
Owner

dw-0 commented Jun 24, 2023

I like the idea and it seems like a rather easy approach and solution to the issue.
Though im not sure if we should do this check everytime after starting KIAUH.
Imagine user has everthing installed and just want to update a component. He would then be shown the message and the script exits, leaving the user unable to do anything. Even uninstalling something to free space up would be impossible.

I think the check should be done somewhere later. Maybe in the install and update menu itself? we could check if any component is already installed, and if its a completely clean system that has no klipper, moonraker etc installed, we could assume the dependencies are also missing and show the warning in red. i would still allow the user to proceed i think. he has been warned, right?
a second case would be to check if anything is installed at all, and if it is but the available disk space is below 5gb, we could print the message in yellow for signaling something like "hey you're likely running out of disk space soon". but let the user proceed here as well.
last but not least: is $HOME really the correct directory to check? don't system packages go onto another partition usually? i don't know that from the top of my head right now.

@cravl-dev
Copy link
Contributor Author

I'm converting this to a draft while I mess with it some more, I have a couple test cases that still aren't working right and I want to refactor a bit to simplify things.

@cravl-dev cravl-dev marked this pull request as draft June 28, 2023 22:28
@dw-0 dw-0 added this to the v6.0.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Alert during pre-install checks if <5(?)GB free space exists on the file system.
2 participants