Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download button fails for names with hash mark (#) #582

Open
Ulysses1337 opened this issue Oct 12, 2023 · 2 comments
Open

Download button fails for names with hash mark (#) #582

Ulysses1337 opened this issue Oct 12, 2023 · 2 comments

Comments

@Ulysses1337
Copy link

Mirror of #213 on the web frontend. If I upload foo#1.txt with curl, the download button gives a 404 because the get link has an unencoded #, so the server will not find /get/hash/foo.

If I upload the same file with the frontend, the download button works, but the filename is truncated at the #.

@aspacca
Copy link
Collaborator

aspacca commented Oct 14, 2023

@Ulysses1337

thanks for reporting the issue, I was able to reproduce

as you mentionedm for the curl upload with frontend giving 404 the problem is that the file is uploaded as foo%231.txt while the link points to foo#1.txt. I will look into urlencoding the filename in the frontend link. minor thing is that will produce urlencoded url probably for every non-ascii chars, including non latin alphabets

I will look into the js for the part on the frontend truncating at #

@aspacca
Copy link
Collaborator

aspacca commented Oct 14, 2023

adding that deleting from frontend is broken as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants