Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting PHP Warning: Declaration of Cassandra\Request\Batch::queryParameters($consistency, array $options = Array) should be compatible with Cassandra\Request\Request::queryParameters($consistency, array $values = Array, array $options = Array) in /var/www/html/php-cassandra/src/Request/Batch.php on line 122 for PHP7 #67

Open
arjunnikhil03 opened this issue Dec 15, 2015 · 4 comments

Comments

@arjunnikhil03
Copy link

PHP Warning: Declaration of Cassandra\Request\Batch::queryParameters($consistency, array $options = Array) should be compatible with Cassandra\Request\Request::queryParameters($consistency, array $values = Array, array $options = Array) in /var/www/html/php-cassandra/src/Request/Batch.php on line 122

@pincher2012
Copy link

And php5.6 too, batch not worked.

@vinothbabu13
Copy link

vinothbabu13 commented Apr 19, 2016

I have fixed this by adding one more param in the following function in src\Request\Batch.php,

public static function queryParameters($consistency, array $options = []){

}

So the above function should be like below,

public static function queryParameters($consistency, array $options = [], array $values = []){

}

@vinothbabu13
Copy link

I have fixed and committed the code in this branch. You can take the pull.
https://github.com/vinothbabu13/php-cassandra

@ezramorse
Copy link

Looks like composer package is still behind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants