Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support JWKS for JWT validation #812

Open
broncha opened this issue Sep 29, 2023 · 2 comments
Open

feat: Support JWKS for JWT validation #812

broncha opened this issue Sep 29, 2023 · 2 comments

Comments

@broncha
Copy link

broncha commented Sep 29, 2023

Hi all,

I am working on adding support for JWKS in Mercure. With this update, you would simply configure the JWKS URL and Mercure would validate the subscriber and publisher JWT based on the Key ID and the keys in the JWKS.

I have everything working (tested the binary with other apps publishing and subscribing). However, I am struggling with timeout on one of the tests. Can anyone have a look at it and point out my mistake with the test?

Here is the commit that adds JWKS support to Mercure broncha@f6d9015

And the test that is timing out is TestSubscribePrivateWithJWKS in subscribe_test.go

@dunglas
Copy link
Owner

dunglas commented Oct 1, 2023

Hi @broncha. Nice feature! Don't hesitate to open a PR, I'll try helping to have the tests green.

@broncha
Copy link
Author

broncha commented Oct 1, 2023

@dunglas Opened a draft PR here #813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants