Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 support #26

Open
akoenig opened this issue Jun 7, 2017 · 7 comments
Open

React 16 support #26

akoenig opened this issue Jun 7, 2017 · 7 comments

Comments

@akoenig
Copy link

akoenig commented Jun 7, 2017

Hi @dtschust, thanks for building redux-bug-reporter! I have one question though. Do you have any plans to support React 16 in order to get rid of the deprecation warning regarding React.createClass in React 15.5?

@dtschust
Copy link
Owner

Hi @akoenig , thanks for asking! Yes, I plan to support React 16 eventually, but I'm not spending a lot of time lately on redux-bug-reporter. I'll probably look into it once React 16 launches. I also accept PRs if you'd like to take a crack at it!

@akoenig
Copy link
Author

akoenig commented Sep 29, 2017

Awesome! :) Now where React 16 landed, do you have time for that? :)

@dtschust
Copy link
Owner

Hi @akoenig , I'll try and get to this in the next few weeks, but am also willing to accept PRs if you need it more urgently :)

@dtschust
Copy link
Owner

dtschust commented Oct 3, 2017

@akoenig I've got a rough branch that I think seems to be working fine with React 16, although my unit tests are failing due to some bugs in the newest version of enzyme. The commits are all over the place and I'll tidy them up before merging, but I'd love feedback if you can confirm how it works for you: https://github.com/dtschust/redux-bug-reporter/tree/bump-versions

@akoenig
Copy link
Author

akoenig commented Oct 4, 2017

Ah @dtschust, that is awesome. Thanks for putting time into it and sorry that my request seemed a bit needy. I just hadn‘t the time to compile the PR 😕

I will work on an app that has to be migrated to React 16 and which uses the Redux Bug Reporter in the next week. Will be able to test the branch then.

Thanks a thousand times for your efforts!

@jrball3
Copy link

jrball3 commented May 17, 2018

@dtschust Where did you guys leave off with this?

@dtschust
Copy link
Owner

@jrball3 sorry, but I'm not actively maintaining this package at the moment. I have an abandoned work in progress branch as listed above that should work with React 16 if you want to try that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants