Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSFT_xWebsite support for FTP websites #81

Open
TheDudeCode opened this issue Jan 13, 2016 · 17 comments · May be fixed by #425
Open

MSFT_xWebsite support for FTP websites #81

TheDudeCode opened this issue Jan 13, 2016 · 17 comments · May be fixed by #425
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.

Comments

@TheDudeCode
Copy link

The MSFT_xWebsite currently lacks support for managing FTP websites. I would like to bring a vote for implementing this.

@tysonjhayes tysonjhayes added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jan 14, 2016
@tysonjhayes
Copy link

Seems like a good idea to me.

@SNikalaichyk
Copy link
Contributor

I was planning to support FTP bindings in pull request #69 but decided to postpone it. It required to rework the logic behind the site's Started/Stopped state.
For example if a site has both FTP and HTTP bindings, and you want the Website to be Stopped, the FTP site will be still Started. As soon as my PR is merged, I will be able to start working on it.

websitewithftpstate

@gigi81
Copy link
Contributor

gigi81 commented Apr 19, 2016

Hello! Any update on this? Last comment is 3 months old. I wonder if @SNikalaichyk had the time to have a look into this. Thanks

@SNikalaichyk
Copy link
Contributor

Hi @gigi81,
Unfortunately no.

@nzspambot
Copy link

@SNikalaichyk is this still on your radar? It look a emm "interesting" one to fix

@SNikalaichyk
Copy link
Contributor

@nzspambot ,
No. Please feel free to implement it.

@nzspambot
Copy link

@SNikalaichyk I'll look at this soonish, I had a thought about this.

What do you think about splitting this into a new module called xFTP so it is not under xWebsite? Where it would create an FTP site and also allow FTP on an existing website if needed?

@tysonjhayes ☝️ your input is also valued please

@tysonjhayes
Copy link

So to show a bit of ignorance, how does this differ from changing a binding/port on a website (something that could be added to xWebsite) and needing to spawn its own resource? I'm good with either one as long as it makes sense.

@nzspambot
Copy link

nzspambot commented Jun 15, 2016

I was thinking about the FTP settings vs a plain FTP binding so

either:

  • a Resource which can change FTP settings eg FTP Authen, FTP Auth, FTP Dir Brow, FTP Ssl, FTP User etc

or

  • add to xWebsite only ability to add FTP bindings

I'm pro former but latter is quicker

@tysonjhayes
Copy link

Wouldn't it be a bit of both though? I'm thinking the former sounds pretty good though.

@nzspambot
Copy link

well former has etc so yes would encapsulate bindings ;)

@nzspambot
Copy link

ok since I can I will start xFTP this weekend

@rosberglinhares
Copy link
Contributor

Waiting for PR #202.

@rosberglinhares
Copy link
Contributor

The PR #202 was closed. Shouldn't we close this issue too?

@johlju
Copy link
Member

johlju commented Apr 25, 2018

I have reopen the PR and labeled it abandoned and hopefully the author wish to continue the work on it, otherwise I hope another contributor want to continue the work.

@johlju johlju added in progress The issue is being actively worked on by someone. help wanted The issue is up for grabs for anyone in the community. and removed help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. labels Apr 25, 2018
@mvandriessen
Copy link

mvandriessen commented Apr 9, 2019

The PR #202 has been closed again, should it be opened again so someone else can work on this. This functionality would be really helpful.

@johlju
Copy link
Member

johlju commented Apr 9, 2019

I think someone else can continue the work and send in a new PR. Can anyone pick up PR #202?

See this how to continue working on an abandoned PR.
https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#how-to-continue-working-on-a-pull-request-pr-when-an-author-contributor-is-unable-to-complete-it

@SteveL-MSFT SteveL-MSFT added this to Help Wanted in powershell/dscresources May 14, 2019
@t3mi t3mi linked a pull request May 20, 2019 that will close this issue
9 tasks
@SteveL-MSFT SteveL-MSFT removed this from Help Wanted in powershell/dscresources Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants