Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionControl.ps1 "corrupts" version number #110

Open
danielniccoli opened this issue Jul 26, 2021 · 1 comment
Open

VersionControl.ps1 "corrupts" version number #110

danielniccoli opened this issue Jul 26, 2021 · 1 comment

Comments

@danielniccoli
Copy link
Contributor

File https://github.com/dsccommunity/DscWorkshop/blob/dev/DSC/Build/Tasks/VersionControl.ps1 causes a "corruption" in the version number. It replaces the PATCH version with the release version. This leads to a version number on the server, that is different than the version number in the configuration repository e.g., Repository: 1.1.3, Server 1.1.1.

According to the Semantic Versioning standard - which I assume is used here - the build number should be added as follows: MAJOR.MINOR.PATCH+BUILD.

@danielniccoli
Copy link
Contributor Author

While writing a patch for it, I noticed that System.Version is used in VersionControl.ps1, which is structured as follows: MAJOR.MINOR.BUILD.REVISION

I think it would be a good idea to explain this in the documentation, so that when Azure DevOps is used, or any of the tools listed below, no changes are applied to the version number that the author didn't expect.

if ($env:BHBuildSystem -in 'VSTS', 'Azure Pipelines', 'AppVeyor') {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant