ADGroup, ADUser: add SamAccountName property #656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #656 +/- ##
===================================
Coverage 98% 98%
===================================
Files 25 25
Lines 3408 3415 +7
===================================
+ Hits 3340 3347 +7
Misses 68 68 |
gaelicWizard
force-pushed
the
SamAccountName
branch
6 times, most recently
from
cb91a2a
to
d1930ca
Compare
gaelicWizard
force-pushed
the
SamAccountName
branch
2 times, most recently
from
f1b5df1
to
895ef7c
Compare
Fix New-ADUser to use '-Name' instead of '-SamAccountName' for specifying the user account name. Change parameter descriptions to clarify that UserName can be more than just SamAccountName.
gaelicWizard
force-pushed
the
SamAccountName
branch
from
895ef7c
to
1fe395a
Compare
Add SamAccountName property to allow setting the name of the group; this requires that the GroupName property be specified with something other than the SamAccountName (e.g., the SID, DN, &c.).
gaelicWizard
force-pushed
the
SamAccountName
branch
5 times, most recently
from
58c5831
to
b302bf0
Compare
Add SamAccountName property to allow setting the name of the user; this requires that the UserName property be specified with something other than the SamAccountName (e.g., the SID, DN, &c.).
…me independently.
gaelicWizard
force-pushed
the
SamAccountName
branch
from
b302bf0
to
97986f5
Compare
gaelicWizard
force-pushed
the
SamAccountName
branch
from
97986f5
to
1fdea03
Compare
|
@gaelicWizard, please can you not update more than one resource in one PR, as it makes it much more difficult to review. Please create a separate PR for each modified resource . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds optional parameter SamAccountName to ADUser and ADGroup resources to allow setting this property separately. This requires that GroupName be specified using something other than the SamAccountName, e.g. SID, DN, UPN, &c.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is