Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Illegal folder names in modstore stops the launcher root directory from being deleted. #338

Open
Tjmaxmillion opened this issue Feb 28, 2024 · 4 comments

Comments

@Tjmaxmillion
Copy link

The mod Create: Interactive has a folder called aux located at "org\valkyrienskies\create_interactive\aux" in the JAR.

When this mod is moved to the modstore the aux folder ends up there meaning the root directory of the launcher can't be deleted until the aux folder is deleted with the command line.

For a normal user it's unlikely for them to find the aux folder and know this is what is preventing them from deleting the root directory of the launcher.
Further I doubt a normal user would know how to use the command line to delete this folder.

Implement something to help with edge cases where Illegal folder/files names are used in jar files?

Image Source
image

@Tjmaxmillion Tjmaxmillion changed the title [Windows] Illegal folder names in modstore from stops the launcher root directory from being deleted. [Windows] Illegal folder names in modstore stops the launcher root directory from being deleted. Feb 29, 2024
@dscalzi
Copy link
Owner

dscalzi commented Feb 29, 2024

Doesnt this sound like a defect with the mod, and not the launcher?

@Tjmaxmillion
Copy link
Author

I don't think the mods creators intended the mods files to be stored outside the JAR file by a user, none the less I did make a issue for the mod too.

But this issue is exclusive to helious because it doesn't store mods in JAR files like other launchers.

@dscalzi
Copy link
Owner

dscalzi commented Feb 29, 2024

The launcher does not extract any files from mod jars?

@GeekCornerGH
Copy link
Contributor

@Tjmaxmillion can I take a look at your distribution file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants