Remove the cweagans/composer-patches patch to prevent whole /web dir might get deleted

[Leksat]

Currently there are two ways to lose /web directory completely:

Apply a patch to Drupal core

We have this code:

drupal-project/composer.json

Lines 76 to 80 in 339c81d

	"patches": {
	"cweagans/composer-patches": {
	"Call the preserve paths hooks" : "https://github.com/SebCorbin/composer-patches/commit/1cb9bacba51f8bba0c5f3f322c3bb61e4ceae974.patch"
	}
	},

It tries to solve the issue described in drupal-composer/preserve-paths#10

However, this does not work. Explained here: drupal-composer/preserve-paths#10 (comment)

Moreover, current setup is pretty confusing and it can lead to not nice situations. For example, this could happen:

• A D7 project was migrated to drupal-composer/drupal-project
• The patch was applied nicely to cweagans/composer-patches package
• During deployment, the patch was not applied to the production installation
• Later, a developer applied a patch to Drupal core locally (and this worked fine because the composer-patches patch was applied on the developer's installation)
• The /web directory was vanished on production during the deployment

Proposed solution:

• remove the current patch
• make a fork of cweagans/composer-patches with the patch applied
• use the fork in drupal-composer/drupal-project

If composer-exit-on-patch-failure is true, and there is an issue with applying a Drupal core patch

composer-exit-on-patch-failure is not part of the composer.json in the 7.x branch

[jcnventura]

I'm not sure if a fork of cweagans/composer-patches just to apply this patch is the best solution.

I think that forcing the patching of that package somehow in the post-create-project-cmd step or maybe also in the pre-install-cmd and pre-update-cmd steps, would be a way more maintainable solution.

[jcnventura]

Also note that composer-exit-on-patch-failure is not part of the composer.json in the 7.x branch.

[Leksat]

forcing the patching of that package somehow in the post-create-project-cmd step or maybe also in the pre-install-cmd and pre-update-cmd steps

I know only these ways to patch a package:

• change "patches" section in composer.json
• remove and re-add the package

Both are not usable for composer pre/post commands.

Maybe @cweagans know other ways?

[jcnventura]

Yes, this would not be done the 'normal' way... It would be a direct call for composer-patches to patch itself. It would probably require some custom PHP code, but most likely it should not be too complicated.

The question is whether that code should be on this project or in composer-patches.. It is somewhat a bug in that package that it is unable to apply a patch to itself on the first install.

[jcnventura]

Just for reference the discussion on this is going on at cweagans/composer-patches#42

[back-2-95]

We created this for D7 projects: https://github.com/druidfi/mona-plugin

See how it's used in: https://github.com/druidfi/mona/blob/master/composer.json

[steinmb]

Existing D7 site that 6 months ago was converted to Composer. During composer install --no-dev we lost all files in web directory.

Not sure how we make sure this not happen again and I am not able to re-create this in dev.

• Composer version 2.2.13
• PHP 7.1.33
• Drupal 7.89 => 7.90 core upgrade

        "patches": {
            "cweagans/composer-patches": {
                "Call the preserve paths hooks" : "https://github.com/jcnventura/composer-patches/compare/1.x...jcnventura:fix-preserve-paths.diff"
            }
        },
        "preserve-paths": [
            "web/sites"
        ]

[driskell]

I reported an issue with meta packages and overlapping preserve paths like this
in drupal-composer/preserve-paths#42 . If the composer patches patch didn’t fix the issue it’s likely this issue instead

[AlexSkrypnyk]

This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one.

Thank you for your understanding and your contributions to the project!