New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove php version from composer.json #462
Comments
This seems like as good a place as any to note that, now that the Drupal version is 8.7, that requirement should be |
I wouldn't necessarily consider this a bug - you can override this in PHPStorm: The default is very useful in that it prevents you from using language level features that don't fit the Drupal minimum requirements.... assuming you plan on contributing your code back to the community. |
It is a bug because it interferes with IDE settings, requiring a user to have to go track that down, as opposed to bumping it (mentioned in that very same link). It would not allow me to do anything at all, and it wasn't clear why or how to rectify that from the IDE. Even so, at this date:
So it sounds like it should be bumped in accordance anyway. |
Allready moved up to 7.0.8 with #518 |
Core 8 composer.json has We could move the PHP requirement to the platform reqs like Ping @webflo @jcnventura |
About platform version constraintsThere are 2 places to determine the PHP platform requirements:
The purpose of The purpose of Which versions to specify in a Drupal site?It is recommended to specify It is also recommended to specify Once the PHP version of your environment is updated, the What should we do in this project?This project includes
|
Yes to remove both. Remove The dependencies already cover that logic and it's not on the template to dictate over them or needing to keep up with them. |
Including this line in composer.json causes PHPStorm to lock certain settings like setting your PHP language level.
When I removed
"php": ">=5.6",
and rancomposer update --lock
, I could then set my language level in PHPStorm, pictured below.I think this might be a bug related to Composer/PHPStorm, but it is not a simple thing for others to find, particularly when they are configuring aspects of PHPStorm for development.
The text was updated successfully, but these errors were encountered: