Create a ../config/sync directory with correct permissions #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this is a very useful and simple/trivial fix, but nothing happens with the PR. Is it because some of the checks failed? I don't see why the checks failed and I don't know how to fix it/rerun the tests. |
|
This PR makes #328 obsolete, I guess. |
This was referenced Aug 27, 2018
|
Should I just close this PR and create a new one for the current version? Any chance of getting it included then? |
|
I think this should be closed |
|
This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one. Thank you for your understanding and your contributions to the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
I considered if the permissions should be set on the parent directory, but I think that should be left to decide for the user. (Please don't discuss - in this PR at least - the usage of 777 versus group write permissions. I just follow the choice already made for the files directory.)