Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create web/libraries directory #228

Closed
SOMERSOFTAndrewCrook opened this issue Dec 14, 2016 · 3 comments
Closed

Create web/libraries directory #228

SOMERSOFTAndrewCrook opened this issue Dec 14, 2016 · 3 comments

Comments

@SOMERSOFTAndrewCrook
Copy link

In composer.json it specifies
"web/libraries/{$name}": ["type:drupal-library"],
but 'libraries', is missing at line 28 in drupal-project/scripts/composer/ScriptHandler.php

@webflo
Copy link
Member

webflo commented Dec 14, 2016

I thought composer creates it automatically, it that wrong?

@SOMERSOFTAndrewCrook
Copy link
Author

SOMERSOFTAndrewCrook commented Dec 15, 2016

When composer runs the script, it creates the following directories, if not present,

'web/modules',
'web/profiles',
'web/themes',

but not the directory web/libraries, so currently for that directory no.

May I suggest that README.md is also updated to indicate that packages of type drupal-library are placed in web/libraries.

Further investigation indicates that if composer (v1.2.1) is directed to download a package into that directory then the directory is created, hence your question in the comment. It is a little unclear why the function creates the directories as they are not needed or why the libraries directory is not made if trying to present a consistent starting point.

@leymannx leymannx changed the title directory libraries not created Create web/libraries directory Jan 12, 2021
@AlexSkrypnyk
Copy link
Collaborator

This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one.

Thank you for your understanding and your contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants