Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video keeps playing after close #215

Open
diomed opened this issue May 16, 2017 · 5 comments
Open

video keeps playing after close #215

diomed opened this issue May 16, 2017 · 5 comments

Comments

@diomed
Copy link

diomed commented May 16, 2017

I open, then close modal with video, but I still hear the sound, so video continues to play.
It's not really closed at all.

@drublic
Copy link
Owner

drublic commented May 22, 2017

Thanks for the report. I am in the middle of a rewrite and will close this bug with the next version.
Are you talking about HTML5 Video or a YouTube/Vimeo… iframe?

@diomed
Copy link
Author

diomed commented May 22, 2017

youtube/vimeo iframe - you can easily see it [hear it that is] in example, after you open it, and close it.

@Zeaphon
Copy link

Zeaphon commented Jun 16, 2019

I know this is probably a stretch and I guess this is mostly abandoned, but any progress on this? The example files are all still incorrectly linked and everything on the documentation seems to clash with whats actually in the zip I can download here.

I tried a lot of things and external scripts to get my modal to pause the video but so far no luck.

@diomed
Copy link
Author

diomed commented Jun 16, 2019

doesn't look abandoned.
just 2 days ago he was updating dependencies.

perhaps he'll fix this issue as well.

@drublic
Copy link
Owner

drublic commented Jun 22, 2019

Hello.

I guess this is due to some rewrite i did a couple of months back. Haven’t had the chance to finish it though. I try my best.
PRs welcome.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants