{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":56421556,"defaultBranch":"master","name":"rust-brotli","ownerLogin":"dropbox","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-04-17T06:01:45.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/559357?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714841395.0","currentOid":""},"activityList":{"items":[{"before":"45f30b46c2d97c27703ef46e93af36ec54549bf4","after":null,"ref":"refs/heads/dependabot/github_actions/dependabot/fetch-metadata-2.1.0","pushedAt":"2024-05-04T16:49:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":"1e26a10b62592046b137623e3f3a4536ceb2eaef","after":"f90551aaf127d103c25d836d2769706f48c39007","ref":"refs/heads/master","pushedAt":"2024-05-04T16:49:48.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Merge pull request #188 from dropbox/dependabot/github_actions/dependabot/fetch-metadata-2.1.0\n\nBump dependabot/fetch-metadata from 1.6.0 to 2.1.0","shortMessageHtmlLink":"Merge pull request #188 from dropbox/dependabot/github_actions/depend…"}},{"before":"cd9d24270465422c8efee1411958144f040a3b96","after":"1e26a10b62592046b137623e3f3a4536ceb2eaef","ref":"refs/heads/master","pushedAt":"2024-05-04T16:49:17.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Merge pull request #181 from nyurik/rm-exec\n\nRemove executable flag from .rs files","shortMessageHtmlLink":"Merge pull request #181 from nyurik/rm-exec"}},{"before":"a0b24f71537453c5a39c9c7b0f96e6a889317807","after":"cd9d24270465422c8efee1411958144f040a3b96","ref":"refs/heads/master","pushedAt":"2024-05-04T16:45:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove unused loop\n\nThe nested loop is only executed once, so made the code much more readable and clearer by removing it.\n\nNote that wrapping add was not needed because `j` is limited to 16.","shortMessageHtmlLink":"Remove unused loop"}},{"before":"8e0b2a87608a6db12c5d66102ec77857a3c8a131","after":"a0b24f71537453c5a39c9c7b0f96e6a889317807","ref":"refs/heads/master","pushedAt":"2024-05-04T16:40:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove unused loop\n\nThe nested loop is only executed once, so made the code much more readable and clearer by removing it.","shortMessageHtmlLink":"Remove unused loop"}},{"before":"bf3db20cd897ca5fb11fcbbdb9ed214fedda4a1b","after":"8e0b2a87608a6db12c5d66102ec77857a3c8a131","ref":"refs/heads/master","pushedAt":"2024-05-04T16:30:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"fix CI\n\n* Bump version to 6.0 (per semver check)\n* Remove unused SIMD use statements\n* hide a few warnings - these are TODOs, and should be fixed in separate PRs\n* do NOT build SIMD as part of MSRV -- doesn't make any sense to combine nightly with MSRV","shortMessageHtmlLink":"fix CI"}},{"before":"b186db9dac6cc95da3672206973b110de8bc9951","after":null,"ref":"refs/heads/dependabot/github_actions/dependabot/fetch-metadata-2.0.0","pushedAt":"2024-04-29T22:24:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"}},{"before":null,"after":"45f30b46c2d97c27703ef46e93af36ec54549bf4","ref":"refs/heads/dependabot/github_actions/dependabot/fetch-metadata-2.1.0","pushedAt":"2024-04-29T22:24:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump dependabot/fetch-metadata from 1.6.0 to 2.1.0\n\nBumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.6.0 to 2.1.0.\n- [Release notes](https://github.com/dependabot/fetch-metadata/releases)\n- [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.6.0...v2.1.0)\n\n---\nupdated-dependencies:\n- dependency-name: dependabot/fetch-metadata\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump dependabot/fetch-metadata from 1.6.0 to 2.1.0"}},{"before":"10083bf70964e8949746cc17d094a8867696fab2","after":"bf3db20cd897ca5fb11fcbbdb9ed214fedda4a1b","ref":"refs/heads/master","pushedAt":"2024-04-25T07:59:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Minor hq.rs cleanup\n\n* Convert `fn StoreLookaheadH10()` to `const STORE_LOOKAHEAD_H_10` (used locally)\n* Inline `fn InitStartPosQueue()`\n* use methods for `struct BackwardMatch`\n* use methods for `struct StartPosQueue`","shortMessageHtmlLink":"Minor hq.rs cleanup"}},{"before":"f53535aabda2cc834c5179f4d82b8f949ac55756","after":"10083bf70964e8949746cc17d094a8867696fab2","ref":"refs/heads/master","pushedAt":"2024-04-25T07:56:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Cleanup BlockSplitIterator\n\n* Use methods instead of fns\n* delete unused `InitBlockSplitIterator`","shortMessageHtmlLink":"Cleanup BlockSplitIterator"}},{"before":"d1f356c60a6caa9e2c390891591a107754400470","after":"f53535aabda2cc834c5179f4d82b8f949ac55756","ref":"refs/heads/master","pushedAt":"2024-04-25T07:55:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove dead code\n\nSeveral giant blocks of code are never used. If they are still needed, we should use conditional compilation, and add it to the CI to avoid bitrot.","shortMessageHtmlLink":"Remove dead code"}},{"before":"f8f5840c812571be60c9ae085db6bed13c85f610","after":"d1f356c60a6caa9e2c390891591a107754400470","ref":"refs/heads/master","pushedAt":"2024-04-25T07:52:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove unused corrosion code\n\nThe corrosion dir and `uncorrode.py` seem to no longer be needed.\n\nThe code is still available in git history, so it is not lost.\n\nRemoving it here allows contributors to focus on just the relevant code without confusion, and prevents \"surprising hidden code\" attacks like in the xz case.","shortMessageHtmlLink":"Remove unused corrosion code"}},{"before":"f1dad2275518d9f96ddbead7e38ee6e305879a82","after":"f8f5840c812571be60c9ae085db6bed13c85f610","ref":"refs/heads/master","pushedAt":"2024-04-18T06:17:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Refactor encode::set_parameter\n\n* return `bool`\n* use match statement","shortMessageHtmlLink":"Refactor encode::set_parameter"}},{"before":"2c601f48c4b6ab107761179efa2579edb7fee8fa","after":"f1dad2275518d9f96ddbead7e38ee6e305879a82","ref":"refs/heads/master","pushedAt":"2024-04-18T06:14:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use proper `self` for Command and related\n\nUse `hide whitespace changes` when reviewing","shortMessageHtmlLink":"Use proper self for Command and related"}},{"before":"6c4cd186f258685d38622fa422ebd2bb0090001b","after":"2c601f48c4b6ab107761179efa2579edb7fee8fa","ref":"refs/heads/master","pushedAt":"2024-04-12T07:08:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Release 5.0.0 with ffi-api disabled by default to avoid ODR issues","shortMessageHtmlLink":"Release 5.0.0 with ffi-api disabled by default to avoid ODR issues"}},{"before":"2ff7b21cabdc21a5485958733c03152034278ffc","after":"6c4cd186f258685d38622fa422ebd2bb0090001b","ref":"refs/heads/master","pushedAt":"2024-04-08T00:52:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Make hex numbers more readable\n\nWhen a hex number is used with bit operations, it tends to be less readable as it gets longer. Hex numbers should have each 4 digits separated by a `_`, and separate from the type - so that we can easily see if the number group has 3 or 4 digits.","shortMessageHtmlLink":"Make hex numbers more readable"}},{"before":"03d5501e5c693a2ba290030859fd3ab6430f7bcc","after":"2ff7b21cabdc21a5485958733c03152034278ffc","ref":"refs/heads/master","pushedAt":"2024-04-07T08:05:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use proper self for BrotliEncoderStateStruct\n\nBig refactoring, updating all BrotliEncoderStateStruct-using functions,\nrenaming them, and converting many to return bool.","shortMessageHtmlLink":"Use proper self for BrotliEncoderStateStruct"}},{"before":"462f73c3f649bde4c5c120e0f51bfbd910475ad3","after":"03d5501e5c693a2ba290030859fd3ab6430f7bcc","ref":"refs/heads/master","pushedAt":"2024-04-07T07:42:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use proper `self` for BlockEncoder\n\nUse `hide whitespace changes` when reviewing","shortMessageHtmlLink":"Use proper self for BlockEncoder"}},{"before":"d7481f648492fddcd0d5ee08862202eae320f110","after":"462f73c3f649bde4c5c120e0f51bfbd910475ad3","ref":"refs/heads/master","pushedAt":"2024-04-06T17:04:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Manually fix several for loops\n\nI used this replacement, and then went through each and reasoned if wrapping can ever happen (mostly it cannot, e.g. -1 is ok if for loop starts at 1)\n\nWhen reviewing, make sure to use \"ignore blanks\" because lots of code was only de-indented.\n\n```diff\n@@\nexpression idx, start, end;\n@@\n- idx = start;\n- while idx < end\n+ for idx in start..end\n {\n {\n ...\n }\n- idx = idx.wrapping_add(1);\n }\n\n@@\nexpression idx, start, end;\n@@\n- idx = start;\n- while idx <= end\n+ for idx in start..=end\n {\n {\n ...\n }\n- idx = idx.wrapping_add(1);\n }\n```","shortMessageHtmlLink":"Manually fix several for loops"}},{"before":"0d633b52ca297c206239e1e58254bf5f95ba223c","after":"d7481f648492fddcd0d5ee08862202eae320f110","ref":"refs/heads/master","pushedAt":"2024-04-06T06:50:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove redundant min/max functions, cleanup use\n\nExtra functions clearly were generated by cross-compiler, and mostly just confuse readers","shortMessageHtmlLink":"Remove redundant min/max functions, cleanup use"}},{"before":"1d8017d079ef30789f42036d91f3f0a91ab36a05","after":"0d633b52ca297c206239e1e58254bf5f95ba223c","ref":"refs/heads/master","pushedAt":"2024-04-06T06:41:17.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use `self` with BackwardMatchMut fn\n\nMove two `init` functions into BackwardMatchMut, moving one of them from another file.","shortMessageHtmlLink":"Use self with BackwardMatchMut fn"}},{"before":"853b5e12b89cd209b14a1bf49d13a4abb553257d","after":"1d8017d079ef30789f42036d91f3f0a91ab36a05","ref":"refs/heads/master","pushedAt":"2024-04-03T08:53:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Make CommandCopyLen line up with one another","shortMessageHtmlLink":"Make CommandCopyLen line up with one another"}},{"before":"61eef57a71f9ac1a3516e8ad7033c3a60a85e279","after":"853b5e12b89cd209b14a1bf49d13a4abb553257d","ref":"refs/heads/master","pushedAt":"2024-04-03T08:33:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use proper `self` for HuffmanTree, and rm init\n\n`HuffmanTree` is used as a copyable struct, and it seems there is never a need for `init` version of it (can simply be assigned where needed), so removed that.\n\nUse `hide whitespace changes` when reviewing","shortMessageHtmlLink":"Use proper self for HuffmanTree, and rm init"}},{"before":"3ff4359f815f15dd5d57bb4d40e3629d08aa6233","after":"61eef57a71f9ac1a3516e8ad7033c3a60a85e279","ref":"refs/heads/master","pushedAt":"2024-04-03T08:31:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Use proper `self` for ZopfliCostModel and ZopfliNode\n\nNote that I intentionally did not move functions together - this can be done later. At this point, I am doing minimal changes to convert everything to proper structs","shortMessageHtmlLink":"Use proper self for ZopfliCostModel and ZopfliNode"}},{"before":"c9afcec684d5c7b37bab624dd7d6961719b6cfc4","after":"3ff4359f815f15dd5d57bb4d40e3629d08aa6233","ref":"refs/heads/master","pushedAt":"2024-04-03T08:07:55.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Remove unused values\n\nRan `cargo clippy -- -A clippy::all -W clippy::no_effect` and fixed them.\n\nMostly removing statements like `0i32;`","shortMessageHtmlLink":"Remove unused values"}},{"before":"f6886b025344c71bc19bf244691760fdcd40c8c5","after":"c9afcec684d5c7b37bab624dd7d6961719b6cfc4","ref":"refs/heads/master","pushedAt":"2024-04-03T07:57:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Bump to 4.0.0","shortMessageHtmlLink":"Bump to 4.0.0"}},{"before":null,"after":"b186db9dac6cc95da3672206973b110de8bc9951","ref":"refs/heads/dependabot/github_actions/dependabot/fetch-metadata-2.0.0","pushedAt":"2024-03-25T22:55:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump dependabot/fetch-metadata from 1.6.0 to 2.0.0\n\nBumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.6.0 to 2.0.0.\n- [Release notes](https://github.com/dependabot/fetch-metadata/releases)\n- [Commits](https://github.com/dependabot/fetch-metadata/compare/v1.6.0...v2.0.0)\n\n---\nupdated-dependencies:\n- dependency-name: dependabot/fetch-metadata\n dependency-type: direct:production\n update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump dependabot/fetch-metadata from 1.6.0 to 2.0.0"}},{"before":"3e526c4cdc027ccc3b421236e8214a31f9f6bb12","after":"f6886b025344c71bc19bf244691760fdcd40c8c5","ref":"refs/heads/master","pushedAt":"2024-03-20T03:04:47.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Tiny manual fix\n\nhere `i` can never exceed a relatively small `BROTLI_NUM_COMMAND_SYMBOLS`, no need for wrapping_add","shortMessageHtmlLink":"Tiny manual fix"}},{"before":"6fae4d3922e41280f4bed91438c3868a4714c6e9","after":"3e526c4cdc027ccc3b421236e8214a31f9f6bb12","ref":"refs/heads/master","pushedAt":"2024-03-20T03:01:51.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Simplify non-wrapping += and *=\n\nUse this replacement file as described in other recent PRs to replace boilerplate code.\n\nFollowed by `cargo fmt --all`\n\n
\nreplacement file content\n\n```diff\n@@\nexpression expr_r, expr_l;\n@@\n-{\n- let _rhs = expr_r;\n- let _lhs = &mut expr_l;\n- *_lhs *= _rhs;\n+expr_l *= expr_r;\n-}\n\n@@\nexpression expr_r, expr_l, i, start, end;\n@@\nfor i in start..end\n{\n- let _rhs = expr_r;\n- let _lhs = &mut expr_l;\n- *_lhs += _rhs;\n+expr_l += expr_r;\n}\n\n@@\nexpression expr_r, expr_l;\n@@\n-{\n- let _rhs = expr_r;\n- let _lhs = &mut expr_l;\n- *_lhs += _rhs;\n+expr_l += expr_r;\n-}\n```\n\n
","shortMessageHtmlLink":"Simplify non-wrapping += and *="}},{"before":"b42042b81dc59a4b3f25645367262fd189d38cc5","after":"6fae4d3922e41280f4bed91438c3868a4714c6e9","ref":"refs/heads/master","pushedAt":"2024-03-18T08:14:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrh","name":"Daniel","path":"/danielrh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47249?s=80&v=4"},"commit":{"message":"Convert while loops into for loops\n\nI used a very powerful tool [coccinelle](https://gitlab.inria.fr/coccinelle/coccinelleforrust) (its C version is used for Linux kernel refactorings). Highly recommend installing it as it has a potential to simplify refactorings while not dealing with regex errors.\n\nTo install it, run\n\n```sh\ncargo install --git https://gitlab.inria.fr/coccinelle/coccinelleforrust\n```\n\nAfterward, create this file as `target/repl2.cocci` with the following content. Using `target/` ensures that it will be ignored by git.\n\n```diff\n@@\nexpression i, end;\n@@\n\n-i = 0usize;\n-while i < end\n+for i in 0usize..end\n-{\n {\n ...\n }\n- i = i.wrapping_add(1);\n-}\n```\n\nand run this command from the root of the repo:\n\n```shell\ncfr -c target/repl2.cocci src/ --apply\ncargo fmt --all\n```\n\nAfterwards, I compiled and removed all unused index variables.","shortMessageHtmlLink":"Convert while loops into for loops"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQYBHdwA","startCursor":null,"endCursor":null}},"title":"Activity · dropbox/rust-brotli"}