Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common model helpers/validators into a single place #318

Open
jathanism opened this issue Feb 22, 2018 · 0 comments
Open

Refactor common model helpers/validators into a single place #318

jathanism opened this issue Feb 22, 2018 · 0 comments
Labels
Milestone

Comments

@jathanism
Copy link
Contributor

Following #317 @narJH27 had this feedback:

This looks great! Just one suggestion from my end, there are too many repetitions of clean_site(), clean_fields() and save() which I feel could easily be moved to a base class from where the specific model classes could subclass and overload the methods if needed. This is just to avoid duplication of the same block of code over and over again.

This is a great idea for the V2 API, to reduce duplication.

@jathanism jathanism added this to the v2.0 milestone Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant