Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in circuit create serializer: Doesn't include the "site" field. #303

Open
jathanism opened this issue Nov 20, 2017 · 0 comments
Open
Labels

Comments

@jathanism
Copy link
Contributor

This isn't caught because we have few use-cases that include top-level objects that aren't using site-specific API endpoints. We are not testing for this either.

e.g. POST /api/circuits/ is hardly tested if at all, while POST /api/sites/1/circuits/ is the bulk of our testing. I'm pretty certain that a test in the former case would fail with an error about missing site (site_id) since this value passed in implicitly in the latter example (more common).

So this isn't an active bug, but it's one I noted while working on the Protocol feature.

@jathanism jathanism added the bug label Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant