Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpc request without timeout #680

Open
mworrell opened this issue Jan 13, 2022 · 0 comments
Open

httpc request without timeout #680

mworrell opened this issue Jan 13, 2022 · 0 comments

Comments

@mworrell
Copy link
Contributor

In:

https://github.com/driebit/ginger/blob/master/modules/mod_ginger_base/support/ginger_http_client.erl#L57

there is a http:request without any timeouts.

If there is a connect problem then this might hang forever (as the default timeout is infinity).
Best is to set a timeout and connect_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mworrell