Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins3 #37

Open
hedenface opened this issue Jul 18, 2017 · 2 comments
Open

Plugins3 #37

hedenface opened this issue Jul 18, 2017 · 2 comments
Labels

Comments

@hedenface
Copy link

Hey @drewkerrigan:

Would you mind if this plugin was included in nagios-plugins 3 as a plugins-python/contrib kind of thing?

I have some cool ideas in mind to make the next major release pretty awesome, and I'd like to start with this plugin!

What are your thoughts?

@drewkerrigan
Copy link
Owner

Absolutely, let you know what you need from my end!

I'll be addressing some of the open PRs today as well.

@hedenface
Copy link
Author

I guess the idea I have is to maintain contrib plugins as git submodules in nagios-plugins repo. The problem here is merging upstream - we almost need to fork each of the projects we use so that we can push to it from within plugins (during version updates) - which would allow us to open up PRs as well.

But this seems pretty complicated for just grabbing some plugins from the innerwebs. Any better ideas are welcome!

It's either that, or we just copy the plugin to a python/contrib folder and hope to remember to update it when we issue releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants