Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for species/reactions/... to be processed directly #78

Open
mephenor opened this issue Nov 11, 2019 · 2 comments
Open

Allow for species/reactions/... to be processed directly #78

mephenor opened this issue Nov 11, 2019 · 2 comments
Labels
feature Issues that aim to introduce new feature in ModelPolisher.
Projects

Comments

@mephenor
Copy link
Collaborator

As @matthiaskoenig mentioned during GSoC, it would be nice to restructure ModelPolisher so it can directly annotate model parts without the necessity to parse the complete model.
This would also allow to test annotation of these components properly and thoroughly.
The first question here is, whether JSBML is able to parse only these parts of a model or if we need to we need to write custom code for this - I haven't had a look at JSBML with regard to this yet.
We would also need to specify which format is consumed, e.g. an SBML snippet with only the respective component.

@mephenor mephenor self-assigned this Nov 11, 2019
@mephenor mephenor added this to Features and refactoring in Release 2.1 Nov 11, 2019
@draeger
Copy link
Member

draeger commented Nov 14, 2019

This could indeed be an interesting feature. However, the key aspect here is not the parsing of a file. It is rather to provide a part of a model to ModelPolisher that is then annotated. To this end, it is sufficient to pass some JSBML data structures to ModelPolisher. Those data structures can come from a larger model, parts of a file, or from other sources. All we need are API functions that can be called on individual model components.

@mephenor mephenor moved this from Features and refactoring to Backlog in Release 2.1 Jan 31, 2020
@mephenor
Copy link
Collaborator Author

I moved some of the annotation logic from BiGGAnnotation into separate classes, so Species, Reaction, GeneProduct and Compartment all have their respective Annotation class and could theoretically be annotated directly using those classes.
There are, however, some places where annotation is dependent on the model id, so this code should be adapted accordingly.
Additionally I need to do something similar for the polishing.

The easiest way right now to implement this would be by using the corresponding JSON representation.
As the classes are already present for parsing JSON models, parsing input should be a matter of simply giving Jackson the information to interpret the data as the correct type.
Output could then be produced as JSON which should be straightforward for the most part, except for information that is not directly present on the Species/Reaction/etc. itself and thus will need some further work in those places.

@Schmoho Schmoho added feature Issues that aim to introduce new feature in ModelPolisher. and removed enhancement labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that aim to introduce new feature in ModelPolisher.
Projects
Release 2.1
  
Todo
Development

No branches or pull requests

3 participants