Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using search from tool bar behavior questions #685

Closed
fitness888 opened this issue Apr 20, 2024 · 5 comments
Closed

using search from tool bar behavior questions #685

fitness888 opened this issue Apr 20, 2024 · 5 comments
Milestone

Comments

@fitness888
Copy link

fitness888 commented Apr 20, 2024

Screenshot 2024-04-20 115610
When I use search from the tool bar sometimes I get different search windows...

Screenshot 2024-04-20 114954

And then other times I get...

Screenshot 2024-04-20 114859

Also...It seems 'search all folders' includes 'search all tree nodes'...perhaps when selecting 'search all folders' by default 'search all tree nodes' should be checked and greyed out.

EDIT: After more testing it seems when the cursor is active on any node, search will then only look for matches in all the node names for the active folder you're in...but if the cursor is active in the note then all the text in that note will be searched, not folder names.
And the cursor location is what determines which search box appears.

@Stefanoko
Copy link

So? I don't see a problem, standard behavior, imo. Same as in earlier versions. When you sit in the tree, it searches tree node names. You sit in the editor, it searches text. For more comprehensive searches, you use the search panel of the right sidebar.

@fitness888
Copy link
Author

So? I don't see a problem, standard behavior, imo. Same as in earlier versions. When you sit in the tree, it searches tree node names. You sit in the editor, it searches text. For more comprehensive searches, you use the search panel of the right sidebar.

Thank you for the confirmation of my 'edit' above.

About the other point I made, am I correct... 'search all folders' include 'search all tree nodes' and possibly greying out the latter when 'search all folders' is selected.

@Stefanoko
Copy link

About the other point I made, am I correct... 'search all folders' include 'search all tree nodes' ...

I think it goes without saying, but sure, greying out would make it unmistakably clear.

@fitness888
Copy link
Author

fitness888 commented Apr 22, 2024

About the other point I made, am I correct... 'search all folders' include 'search all tree nodes' ...

I think it goes without saying, but sure, greying out would make it unmistakably clear.

I remember seeing that scenario in the Find options [Resource Panel]...anyway it's a great well thought out program! I've tossed away 3 other programs by transferring their data here...nice to have general note info, phone/address book and to-do all in 1 configurable program.

@Stefanoko
Copy link

Stefanoko commented Apr 23, 2024

About the greying out of some search options: You are right, it would make sense to be consistent in both, the sidebar and the search dialog. I am sure the author has been reading along and made a note of your suggestion. @dpradov has been incredibly effective in raising this program onto a whole new level, in a very short time. This requires strong prioritizing, and I'd say, the greying out is probably not a high priority issue.

nice to have general note info, phone/address book and to-do all in 1 configurable program.

I fully agree. And it's capable of much more than mere info dumps and data storage. I also use it for work-in-progress, proofreading, brainstorming, outlining, typing up articles and blog posts ...

Just like you, I tossed most of my other programs in favor of Keynote. And that includes bought licensed apps, too. Comfort, portability, speed, support even — Keynote is hard to beat.

dpradov added a commit that referenced this issue May 1, 2024
… all tree Nodes" vs "Search Hidden nodes" in Find form

Ref: #685
@dpradov dpradov added this to the 1.9.3 milestone May 5, 2024
@dpradov dpradov closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants