Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify options for Add Tree Node (suggestion) #673

Closed
mgayamoreno opened this issue Apr 2, 2024 · 4 comments
Closed

Clarify options for Add Tree Node (suggestion) #673

mgayamoreno opened this issue Apr 2, 2024 · 4 comments
Milestone

Comments

@mgayamoreno
Copy link

The options in the Tree Menu for “Add Tree Node” are not very clear when you start using the program. For instance, “Insert Node” and “Add Node” sound quite similar. Additionally, “Add Sibling” is not intuitive.

In my opinion:

  • “Insert Node” would be clearer if it were named “Add Node Above” or "Add Node above current Node"
  • “Add Sibling” could be better labeled as “Add Node Below” or "Add Node below current Node" and it should appear below the “Add Node Above” option
  • “Add Node” could remain as it is or be renamed to “Add New Node”
  • “Add Child” could stay as the last option without any changes

Imagen38

@dpradov
Copy link
Owner

dpradov commented Apr 2, 2024

It is very possible that you are right. These names have been like this since the first versions of KeyNote and I have not changed it. I haven't seen them bad either, to be honest.

For me it is intuitive to think of "Insert Node" with the current behavior. And maybe "Add Node Above" could also suggest adding a parent, a node that is above the current one, in the hierarchy...

In any case, I would like to know what other users think, especially those who have English as their native language. If I change it, let's try to make it towards something where there is a certain consensus.

@mgayamoreno
Copy link
Author

Asking English native speakers sounds right to me. I also understand your point when you say that ‘"Add Node Above’ could potentially suggest adding a parent node, which is above the current one in the hierarchy". Perhaps a more precise set of options would be:

  • Add Sibling Above
  • Add Sibling Below
  • Add Sibling at the Bottom
  • Add Child
  • Add Parent (a new function)

However, as you mentioned, it’s wise to wait for input from native English speakers and other users to ensure the best choice

@Stefanoko
Copy link

Stefanoko commented Apr 3, 2024

I am not a native speaker, but I have always been using apps with an English interface only. Other tree-style wikis, outliners, hierarchical note-taking etc have various captions — Add, Insert, Hoist, Promote, Demote — I have no personal preference. To me, the logical appearance/ordering is more important than naming conventions. From top to bottom:

Add above
Add child
Add below

That being said, I have no objections to renaming the entries to whatever other users may find more helpful to remember.

@dpradov
Copy link
Owner

dpradov commented Apr 3, 2024

Thinking about it better, I don't think there is a problem with using "Add above", and that it is correctly understood as sibling, because adding a parent would be complex to understand since all nodes except for the first level ones already have a parent.

On the other hand, I share with @Stefanoko that the order is important and clarifying. Therefore I would see something like this as ok:

"Add Above [sibling]" (Instead of "Insert node")
"Add Child"
"Add Below [sibling]" (Instead of "Add sibling")
"Add Last sibling" (instead of "Add node")

or simply:

"Add Above" (Instead of "Insert node")
"Add Child"
"Add Below" (Instead of "Add sibling")
"Add Last [sibling]" (instead of "Add node")

dpradov added a commit that referenced this issue Apr 28, 2024
…TV context menu

Changed the order and the captions:

"Add Above"        (Instead of "Insert node")
"Add Child"
"Add Below"        (Instead of "Add sibling")
"Add Last sibling" (instead of "Add node")

Ref: #673
@dpradov dpradov added this to the 1.9.3 milestone May 5, 2024
@dpradov dpradov closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants