Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource panel>favorites, not auto populating? #655

Closed
fitness888 opened this issue Mar 10, 2024 · 32 comments
Closed

resource panel>favorites, not auto populating? #655

fitness888 opened this issue Mar 10, 2024 · 32 comments

Comments

@fitness888
Copy link

fitness888 commented Mar 10, 2024

v.1.9.0 .1
In Tools>options>advanced, Reload Resource panel data when displaying is checked but resource panel>favorites is always blank. I must manually refresh it every time I start Keynote NF.
Is there a way to avoid this?

Thank you

@Stefanoko
Copy link

Strange. It works alright here. No need to refresh at all.

What I would like to know: Is there any reason to not enable this setting? What advantage do I get by disabling it?

@fitness888
Copy link
Author

Strange. It works alright here. No need to refresh at all.

What I would like to know: Is there any reason to not enable this setting? What advantage do I get by disabling it?

I only enabled it to see if it would help...I've had this option with and without the check mark. I read others were having the same issue with blank favorites on program restart...however it was with an older version so I thought it might be fixed in the latest version.

@fitness888
Copy link
Author

Strange. It works alright here. No need to refresh at all.

What I would like to know: Is there any reason to not enable this setting? What advantage do I get by disabling it?

Favorites in Resource Panel need to be refreshed in 1.8.xx #631

#631

@dpradov
Copy link
Owner

dpradov commented Mar 11, 2024

Could you attach the options (keynote.ini) that you use? Before attaching it, you can delete the values of those options that could contain personal information, such as the name of the last opened file, or search history, for example. I would just like to know what other options you may have activated that could be influencing it (if any)
Did you install the app through the installer? It is to know if you have the folder structure that is installed in the latest version, where certain folders are assigned certain access permissions.
Do you only have a problem reloading favorites? Doesn't it happen to you with Templates, Macros or Plugins?

I remember the issue you point out (#631). But I couldn't identify why it was happening, honestly.
I'll end up locating it, yes.

@fitness888
Copy link
Author

Could you attach the options (keynote.ini) that you use? Before attaching it, you can delete the values of those options that could contain personal information, such as the name of the last opened file, or search history, for example. I would just like to know what other options you may have activated that could be influencing it (if any) Did you install the app through the installer? It is to know if you have the folder structure that is installed in the latest version, where certain folders are assigned certain access permissions. Do you only have a problem reloading favorites? Doesn't it happen to you with Templates, Macros or Plugins?

I remember the issue you point out (#631). But I couldn't identify why it was happening, honestly. I'll end up locating it, yes.

Yes I installed the app through the installer.
I only have a problem reloading favorites...nothing else is a problem.
It won't allow keynote.ini to be attached.
Can I send it to you another way?

@dpradov
Copy link
Owner

dpradov commented Mar 12, 2024

It won't allow keynote.ini to be attached.

It is enough that you include it in a .zip file

@fitness888
Copy link
Author

fitness888 commented Mar 12, 2024

It won't allow keynote.ini to be attached.

It is enough that you include it in a .zip file

Can't upload .7z file so I copied into xcel.

@dpradov
Copy link
Owner

dpradov commented Mar 12, 2024

Please, use a ".zip" file, not a ".7z"

@fitness888
Copy link
Author

fitness888 commented Mar 12, 2024

Please, use a ".zip" file, not a ".7z"

The only free zip file program that I know of is 7-Zip file manager...WinZip costs to use. "Either utility can open any type of zip file (i.e. 7-Zip can open WinZip files and visa versa)"...too bad this web site doesn't allow using .7z files.
Thanks for trying.

@Stefanoko
Copy link

You can use 7-Zip to create regular zip-archives.
Or use another freeware zipper:
https://www.portablefreeware.com/index.php?id=2397
https://www.portablefreeware.com/index.php?id=1048
https://www.portablefreeware.com/index.php?id=1278

To upload an ini-file, it should suffice to simply rename its extension from .ini to .txt, afaik.

@fitness888
Copy link
Author

fitness888 commented Mar 12, 2024

Please, use a ".zip" file, not a ".7z"

Thank you Stefanoko for the suggestion of changing .ini to .txt so that's what I did.
Here you go dpradov:
ini file.txt

I converted this to a .zip file format:
keynote ini .zip

edit: I'm not seeing anything showing up when I click on either file...

@Stefanoko
Copy link

It works fine from here. I was able to download both, your zip and the txt-file.

@fitness888
Copy link
Author

It works fine from here. I was able to download both, your zip and the txt-file.

Yes it does today but did not yesterday after uploading...maybe it takes some time to load.

@fitness888
Copy link
Author

Please, use a ".zip" file, not a ".7z"

I should mention...the blank 'favorites' tab only occurs when it's the active tab. For example if I last used the 'find' tab before closing Keynote NF then after reopening the program I then click on the 'favorites' tab it will be properly populated. However if the 'favorites' tab is the last used before closing Keynote NF then after reopening the program there will be no data showing...I must then click on another tab and go back to 'favorites' for data to populate.

@Stefanoko
Copy link

Yes, indeed. Now I can reproduce it, too. The panel comes up empty after restart.

@fitness888
Copy link
Author

I should have been more clear at the start of this thread...dpradov could have then reproduced it on demand.

@dpradov
Copy link
Owner

dpradov commented Mar 15, 2024

I should have been more clear at the start of this thread...dpradov could have then reproduced it on demand.

I assumed from the beginning that this could be the situation where it would be occurring. But it works correctly for me that way too. Let's see if using your configuration file I can also get it to fail and I can see what is happening.

dpradov added a commit that referenced this issue Mar 15, 2024
…omplete"

I can't reproduce issue #655. Maybe this small change could prevent the issue, but I'm not sure.
@fitness888
Copy link
Author

I should have been more clear at the start of this thread...dpradov could have then reproduced it on demand.

I assumed from the beginning that this could be the situation where it would be occurring. But it works correctly for me that way too. Let's see if using your configuration file I can also get it to fail and I can see what is happening.

Thanks dpradov...

@dpradov
Copy link
Owner

dpradov commented Mar 17, 2024

Please tell me if you notice any differences with the new version. The problem is that it doesn't happen to me and I don't see anything in the code that justifies this behavior.
I have made some changes but I'm not sure it can really solve the problem and either way it works for me with and without the change.

If it continues to fail you, I will look for another solution.

@fitness888
Copy link
Author

Please tell me if you notice any differences with the new version. The problem is that it doesn't happen to me and I don't see anything in the code that justifies this behavior. I have made some changes but I'm not sure it can really solve the problem and either way it works for me with and without the change.

If it continues to fail you, I will look for another solution.

OK I'll try 1.9.1 .01...thanks!

@fitness888
Copy link
Author

fitness888 commented Mar 17, 2024

Question...
kntSetup_1.9.1.1.exe does not install into the same directory that the current program [KeyNote.NF_1.9.0 .1] is in. It does not allow me to choose an installation path but instead installs into a new folder and I then have to copy and paste the old 'Profiles' folder into the new installation.
Should I just copy all the KeyNote.NF_1.9.1.1.zip files excluding the 'Profiles' folder and overwrite the existing KeyNote.NF_1.9.0 .1. installation?

@dpradov
Copy link
Owner

dpradov commented Mar 17, 2024

Did you change its location after installing the previous version? Because in principle, when the installer recognizes that there is a previous installation, it does not request any new path, but rather uses the one from the previous installation.
Actually the profiles folder would be the only one you should incorporate from your previous installation. The only thing that has been modified in that folder has been Profiles\Help\keynote.ini. (You can respect last version of that file, but it's not important anyway.

@fitness888
Copy link
Author

fitness888 commented Mar 17, 2024

Did you change its location after installing the previous version? Because in principle, when the installer recognizes that there is a previous installation, it does not request any new path, but rather uses the one from the previous installation. Actually the profiles folder would be the only one you should incorporate from your previous installation. The only thing that has been modified in that folder has been Profiles\Help\keynote.ini. (You can respect last version of that file, but it's not important anyway.

This is where my update installs...note the location:
D:\KeyNote NF\KeyNote NF
The update installs into its own new folder as a sub-folder of the original installation instead of overwriting the original installation.
Of course I know how to fix this but this shouldn't happen.
I'll let you know how the 'Favorites' fix works out.

@fitness888
Copy link
Author

fitness888 commented Mar 18, 2024

Please tell me if you notice any differences with the new version. The problem is that it doesn't happen to me and I don't see anything in the code that justifies this behavior. I have made some changes but I'm not sure it can really solve the problem and either way it works for me with and without the change.

If it continues to fail you, I will look for another solution.

Unfortunately it did not fix the 'Favorites' problem...but we all know the work around.

Would you know the registry key location for the installation path for KeyNote NF? I'll correct for the installation location error as mentioned in prior post.

@dpradov
Copy link
Owner

dpradov commented Mar 18, 2024

Would you know the registry key location for the installation path for KeyNote NF? I'll correct for the installation location error as mentioned in prior post.

The easiest thing is to uninstall the version you have (keeping a copy of the Profiles folder), using the program "unins000.exe" and then install it again. It should ask you where to install and you shouldn't have any problems.

@fitness888
Copy link
Author

Would you know the registry key location for the installation path for KeyNote NF? I'll correct for the installation location error as mentioned in prior post.

The easiest thing is to uninstall the version you have (keeping a copy of the Profiles folder), using the program "unins000.exe" and then install it again. It should ask you where to install and you shouldn't have any problems.

Thanks!

dpradov added a commit that referenced this issue Mar 23, 2024
…assions

I was finally able to reproduce this issue once, enough to identify and fix it

With the help of the 3rdParty TFormStorage control (RxPlacement.pas) KeyNote recovers the position and state of the windows (saved in the keynote.mru file). This occurs when the main KeyNote window is displayed, before it is activated.
From what I had been observing, it seemed that this process ( =>TFormPlacement.RestorePlacement) ended before continuing to process other messages. But it didn't have to be that way.
Sometimes (in my case very rare occasions) the Activate message (on the main form) is received before that process has finished. In this case, the active tab in the resources panel may not have been restored yet. But nevertheless, it is in FormActivate where the initial loading of the resource panel is carried out (on its active tab)
Fortunately the TFormStorage control offers an event that reports the completion of the restore placement process.

(In my case it is something very, very unusual. Few minutes after adding the code that clearly corrected the problem, the favorites panel began showing correctly on the startup, even commenting the new code)

Refs:
 Favorites in Resource Panel need to be refreshed in 1.8.xx #631
 "Resource Panel>Favorites, not autocomplete" #655
@fitness888
Copy link
Author

fitness888 commented Mar 27, 2024

Please tell me if you notice any differences with the new version. The problem is that it doesn't happen to me and I don't see anything in the code that justifies this behavior. I have made some changes but I'm not sure it can really solve the problem and either way it works for me with and without the change.

If it continues to fail you, I will look for another solution.

Hello dpradov...
After much trial and effort I found 2 ways to reproduce this behaviour on demand.
1] When KeyNote NF opens to maximized window the favorites window needs refreshing...BUT when KeyNote NF does not open to maximized window instead opens to any other size window the favorites window will then populate 100% and does not need refreshing.
2] When KeyNote NF is the only tab in the resource panel it will then populate 100% and does not need refreshing.

@dpradov
Copy link
Owner

dpradov commented Mar 27, 2024

Thanks for the effort
It could be, it is possible that in those cases it is happening, but from what I finally found out, I think it can occur in other more uncontrolled circumstances (from the tests I have done)
Have you not seen the comment stating that I have already corrected this issue, along with its explanation?

@fitness888
Copy link
Author

fitness888 commented Mar 27, 2024

Thanks for the effort It could be, it is possible that in those cases it is happening, but from what I finally found out, I think it can occur in other more uncontrolled circumstances (from the tests I have done) Have you not seen the comment stating that I have already corrected this issue, along with its explanation?

Yes I did read your findings, but you mentioned not being able to reproduce the issue on demand so I offered a way to do just that thinking it would further help you.
Is the fix coming in the next update?

"In my case it is something very, very unusual. Few minutes after adding the code that clearly corrected the problem, the favorites panel began showing correctly on the startup, even commenting the new code"

That is mysterious?

@dpradov
Copy link
Owner

dpradov commented Mar 27, 2024

Is the fix coming in the next update?

Yes

That is mysterious?

No. Simply that the process of recovering window properties (in .mru) can usually happen quickly, before the app need them, but sometimes not. That can depend on many external items.

Possibly following what you indicate I could have forced it more easily, but in the end it was not necessary. I have clearly seen the source of the problem (regardless of whether it may be difficult to reproduce)

@fitness888
Copy link
Author

Is the fix coming in the next update?

Yes

That is mysterious?

No. Simply that the process of recovering window properties (in .mru) can usually happen quickly, before the app need them, but sometimes not. That can depend on many external items.

Possibly following what you indicate I could have forced it more easily, but in the end it was not necessary. I have clearly seen the source of the problem (regardless of whether it may be difficult to reproduce)

Glad it all worked out!
Any thoughts on my other thread... Normal vs maximum tree width #668

@dpradov dpradov closed this as completed Apr 1, 2024
@fitness888
Copy link
Author

fitness888 commented Apr 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants