Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal/Dialog): Add option to not close previous modal if user open next one #3518

Closed
1 task done
anna777x opened this issue May 17, 2024 · 7 comments
Closed
1 task done
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@anna777x
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

How it works now:

  1. user clicks on button which open first modal dialog
  2. user do some action inside first modal dialog
  3. next system shows new 'error' modal to user and hides first modal at same time
  4. user clicks 'OK' on error modal and after that first modal is showed again

so I need first modal is showed all time until user don't close it by himself

Describe the solution you'd like

I suggest to make it as parameter -> to hide previous dialogs/modals or not.
because now looks like new modal close first dialog and it can to fear user.

Additional context

No response

@anna777x anna777x added the enhancement New feature or request label May 17, 2024
Copy link

bb-auto bot commented May 17, 2024

@anna777x Thank you for contacting us. We will give feedback later.

@bb-auto bb-auto bot added this to the v8.5.0 milestone May 17, 2024
@anna777x anna777x changed the title feat(): Add option to not close previous modal if user open next one feat(Modal/Dialog): Add option to not close previous modal if user open next one May 17, 2024
@ArgoZhang
Copy link
Collaborator

ArgoZhang commented May 18, 2024

@anna777x thank you for contacting us.

I completely understand your needs and we have discussed this issue very early on. There are some unclear issues regarding interaction.

  1. How to handle masks when there are multiple pop-up windows
  2. How to close the pop-up window when clicking on the mask
  3. Added conflicts between multiple pop-up windows and some other functions.

Can you submit a PR? I can invite you to the project and try to make changes on another branch. If the function is normal, we will merge it into the main branch.

@anna777x
Copy link
Collaborator Author

Hi, I'd like to do it, but I couldn't create PR

image

I've also wanted to push some small fixes, but it doesn't allow to do it as well
image

@ArgoZhang
Copy link
Collaborator

ArgoZhang commented May 21, 2024

@anna777x I have sent an invite to you. please confirm that. thank you very much.

@anna777x
Copy link
Collaborator Author

yes, I'm in project. so what's next?

@ArgoZhang
Copy link
Collaborator

yes, I'm in project. so what's next?

create a new branch and push it into the repo.

@anna777x
Copy link
Collaborator Author

I've created 'dev-multiple-modals' branch. I think maybe we can start by using Named Cascading Parameter and at leats give chance to close specific modal. But I'll think about it tomorrow. Have a good day!

@ArgoZhang ArgoZhang modified the milestones: v8.5.0, v8.6.0 May 31, 2024
@dotnetcore dotnetcore locked and limited conversation to collaborators May 31, 2024
@ArgoZhang ArgoZhang converted this issue into discussion #3606 May 31, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants