Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi Selection to ComboBox #9027

Open
AchimStuy opened this issue Apr 15, 2024 · 1 comment
Open

Add Multi Selection to ComboBox #9027

AchimStuy opened this issue Apr 15, 2024 · 1 comment
Labels
Enhancement Requested Product code improvement that does NOT require public API changes/additions

Comments

@AchimStuy
Copy link

ListBox has SelectionMode property, which can be set to Multiple or Extended. ComboBox shared the CanSelectMultiple property, which is set to false initially. Setting it to true would require:

  • the popup to stay open,
  • each ComboBoxItem to be rendered as CheckBox to be checked and unchecked,
  • to render also a three state CheckBox in the closed DropDown in order to select / unselect all.

It might make sense to make ComboBox inherit MultiSelector.

I could also implement the feature, if I get some guidance (e.g. on which branch to implement).

@miloush
Copy link
Contributor

miloush commented Apr 15, 2024

Related: #8861

Note that you concerns are mostly UI related and that is really the last concern here (and possibly apart from keeping popup open they are questionable as defaults, ListBox also doesn't have check boxes).

Making the controls inherit from MultiSelector is a good start. There will be enough virtualization issues to tackle.

@harshit7962 harshit7962 added Enhancement Requested Product code improvement that does NOT require public API changes/additions and removed Untriaged labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Requested Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

3 participants