-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using solid border for selected control in the DemoConsole application. #11362
Using solid border for selected control in the DemoConsole application. #11362
Conversation
winforms/src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignerUtils.cs Lines 159 to 169 in 88abeb8
I am not sure if there is a case that will trigger |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11362 +/- ##
===================================================
+ Coverage 74.26862% 74.27149% +0.00287%
===================================================
Files 3025 3025
Lines 626861 626861
Branches 46742 46742
===================================================
+ Hits 465561 465579 +18
+ Misses 157955 157938 -17
+ Partials 3345 3344 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Updated the |
Fixes #11353
Proposed changes
selectionBorderBrush
to useSystemColors.ControlDarkDark
instead ofColor.Transparent
as backcolorRegression?
Risk
Screenshots
Before
The selected control has a dashed border in the DemoConsole application.
After
The selected control should have a solid border in the DemoConsole application.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow