Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stomp on *DependsOn properties #2 #9755

Open
JanKrivanek opened this issue Feb 16, 2024 · 2 comments · May be fixed by #10122
Open

Don't stomp on *DependsOn properties #2 #9755

JanKrivanek opened this issue Feb 16, 2024 · 2 comments · May be fixed by #10122
Labels

Comments

@JanKrivanek
Copy link
Member

Context

There are couple sdk ***DependsOn properties that allow injecting custom target as dependencies of sdk targets. However big portion of those properties are force set within sdk.targets - so users'd need to include sdk.targets explicitly to be able to set them (we even document a need for this workaround in the documentation mentioned below).

#4922 fixed couple, #9703 fixed one, but we have still dozens that we force overwrite.

e.g. the externally documented Commonly overridden DependsOn properties

But there are others that seem as potentially usefull - CoreBuildDependsOn, RebuildDependsOn, RunDependsOn, PublishDependsOn etc. etc.

Suggestion

Select a usefull subset (or probably all?) of the DependsOn properties in common target files (search) and redefine those with the additive pattern:

<SomeDependsOn>
   value1;
   value2
</SomeDependsOn>

--->

<SomeDependsOn>
   $(SomeDependsOn);
   value1;
   value2
</SomeDependsOn>
@baronfel
Copy link
Member

Enforcing this rule could be an interesting BuildCheck

@JanKrivanek
Copy link
Member Author

Enforcing this rule could be an interesting BuildCheck

Would such properties by manualy configured by the author+user, or might there be any 'magic' how to detect properties that should actually behave as items?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants