Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log item Includes, Removes and Updates during evaluation #10103

Open
KirillOsenkov opened this issue May 5, 2024 · 3 comments
Open

Log item Includes, Removes and Updates during evaluation #10103

KirillOsenkov opened this issue May 5, 2024 · 3 comments
Labels
Area: BuildCheck Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging triaged

Comments

@KirillOsenkov
Copy link
Member

One of the biggest missing features in logging that keeps hurting us is we don't log item includes, removes and updates during evaluation, with the source location where it happened.

We do log the final set of all items after evaluation is done, but it is currently impossible to see where a specific item was added during evaluation.

We should consider logging a TaskParameterEventArgs perhaps (even though the same is not the best fit semantically), because we already have all the infrastructure for items that are logged during target execution. We can reuse the same infrastructure during evaluation as well.

One potential pitfall here is perf, so need to be careful and measure eval perf before and after. Maybe only do this when the binary logger is present.

This is in complement for the similar request for properties:
#2711

@KirillOsenkov KirillOsenkov added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging labels May 5, 2024
@AR-May
Copy link
Member

AR-May commented May 7, 2024

Team triage: it seems that we will need to fix this for the BuildCheck user story too. Let's add it there as an item.

@danmoseley
Copy link
Member

I would expect perf will indeed be a problem.

@JanKrivanek
Copy link
Member

We will experiment with analgous data for props (possibly as part of, or continuation of #10009) - I'd hope that if we accumulate and properly deduplicate/compress the info (especially the names and locations, that will largely repeat) and then send everything in a single blob, the perf might not get that big of an impact. If it's still a deal breaker, than we can scope it only to the user code (the term is yet to be exactly defined) in the default mode.

@AR-May AR-May added the triaged label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BuildCheck Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging triaged
Projects
None yet
Development

No branches or pull requests

4 participants