Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor work items left for CSharpToLinqTranslator #33639

Open
13 tasks
Tracked by #29754
roji opened this issue Apr 29, 2024 · 0 comments
Open
13 tasks
Tracked by #29754

Minor work items left for CSharpToLinqTranslator #33639

roji opened this issue Apr 29, 2024 · 0 comments

Comments

@roji
Copy link
Member

roji commented Apr 29, 2024

  • Review whether more calls of ResolveType() should be done while supplying a genericParameterMap. For example, the expression could be referencing a generic type parameter from the containing type.
  • Add tests for anonymous type, different closures, nested generics, indexers, records with.
  • Add up-cast when a hidden member is accessed/invoked (see Implement precompiled queries #33297 (comment))
  • Check binary UnsignedRightShiftExpression
  • Separate out EF Core-specific logic (EF Core would extend this visitor)
  • We match Roslyn type parameters by name, not sure that's right; also for the method's generic type parameters
  • Test invoking extension without extension syntax (as static)
  • Multiple overloads of Add() when translating list initializers
  • Dictionary initializer, where each ElementInit has more than one expression
  • Cache closed anonymous types
  • ArrayCreation: multi-dimensional array
  • ElementAccessExpressionSyntax over non-array
  • DbSet local symbol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants