Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceBondStateChangedEventArgs should inherit from DeviceEventArgs rather than just EventArgs #793

Open
axa88 opened this issue Jan 2, 2024 · 3 comments

Comments

@axa88
Copy link

axa88 commented Jan 2, 2024

DeviceBondStateChangedEventArgs should inherit from DeviceEventArgs rather than just EventArgs and the property Device should be removed falling back to that of DeviceEventArgs

It's obvious from the description of DeviceEventArgs that this was the intention anyway since they are both events in IAdapter
/// Event arguments for device events in IAdapter

@smsissuechecker
Copy link

Hi @axa88,

I'm the friendly issue checker.
It seems like (100.00 %) you haven't used our issue template 😢 I think it is very frustrating for the repository owners, if you ignore them.

If you think it's fine to make an exception, just ignore this message.
But if you think it was a mistake to delete the template, please close the issue and create a new one.

Thanks!

@axa88
Copy link
Author

axa88 commented Jan 2, 2024

Also shouldn't members of derived EventArgs all be properties rather than what it is now, a mix of properties and fields?
better for consistent serialization handling i would think, no?

@axa88
Copy link
Author

axa88 commented Mar 21, 2024

Inheriting would make some testing and generic handlers more convenient, and i dont see it is a breaking change but could be wrong...
@janusw if this isnt under consideration please feel free to close, maybe im the only one to see things this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants