Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to calculate advertising interval #775

Open
midoragh opened this issue Nov 9, 2023 · 3 comments
Open

Support to calculate advertising interval #775

midoragh opened this issue Nov 9, 2023 · 3 comments

Comments

@midoragh
Copy link
Contributor

midoragh commented Nov 9, 2023

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Steps to reproduce

  1. Get advertising info from DeviceAdvertised event

Expected behavior

Device info in DeviceAdvertised event should contain property like DateTime AdvertisementReceived
this would allow a more precise calculation of the advertisement interval (instead of using the time when the event reaches the app)

Actual behavior

AdvertisementReceived is not available

Crashlog

No crash

Configuration

Version of the Plugin: 3.0

Platform: Android 13

Device: Nokia C32

@smsissuechecker
Copy link

Hi @midoragh,

I'm the friendly issue checker.
Thanks for using the issue template 🌟
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

@janusw
Copy link
Member

janusw commented Nov 9, 2023

Device info in DeviceAdvertised event should contain property like DateTime AdvertisementReceived

One can certainly add such a property ...

this would allow a more precise calculation of the advertisement interval (instead of using the time when the event reaches the app)

... but I doubt it will make much of a difference. I would expect that the time when the event reaches the app is reasonably close to the time when the advertisement is received by the library. (Of course one can just try it, in order to see if there is a significant difference.)

@axa88
Copy link

axa88 commented May 8, 2024

looking at Nordic device implementation, imho the gold standard
minimum possible advertising interval is 20ms. recommended fast interval 30ms
https://devzone.nordicsemi.com/cfs-file/__key/communityserver-discussions-components-files/4/6708.Core_5F00_v4.1.pdf

Typical employ slower interval of 62.5ms + small random value, to not overwhelm devices.
https://stackoverflow.com/q/76337421/5122089

Its all but inconceivable that a callback contained in the same executable will contribute any significant overhead to this calculation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants