Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

[FEATURE]: Simplify process of creating secrets for GrantBucketAccess #21

Open
shanduur opened this issue Aug 4, 2023 · 0 comments
Open
Labels
area/api Indicates an issue on COSI api area. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@shanduur
Copy link
Contributor

shanduur commented Aug 4, 2023

Are you interested in contributing to the development of this feature?

Yes

Is your feature request related to a problem? Please describe.

The credentials returned in the Driver is of type map[string]string. It is sometimes confusing to new developers how to structure this value for available protocols.

Describe the solution you'd like.

I would like to have functions that simplify the creation of the credentials, e.g.:

func S3Credential(secretKeyID, secretKey, bucketName string, endpoint *url.URL) (map[string]string, error)

Additionally, for the purpose of custom functions that can be written in the future, provide each map key in form of constant, e.g.:

import "sigs.k8s.io/container-object-storage-interface-provisioner-sidecar/pkg/consts"

const (
	S3SecretAccessKeyID string = consts.SecretAccessKeyID
	// ...
)

Describe alternatives you've considered.

Importing the sigs.k8s.io/container-object-storage-interface-provisioner-sidecar/pkg/consts and creating the credentials by hand.

Additional Information

N/A

@shanduur shanduur added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. area/api Indicates an issue on COSI api area. labels Aug 4, 2023
@shanduur shanduur added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api Indicates an issue on COSI api area. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant