Which-key popup too small in emacsclient

[TheSirC]

What did you expect to happen?

When typing SPC w, the which-key popup should have all of his lines visible.

What actually happened?

When typing SPC w, the which-key popup is cropped but only using emacsclient.

Describe your attempts to resolve the issue

I searched in the which-key repository and there is an issue upstream open for this problem but the workaround given that seems to make consensus is not applicable (to my understanding) to this situation :
as Doom is activating which-key how is this fix supposed to work ? How would I adapt it in the case of Doom ?

Steps to reproduce

1. Connect to a Emacs daemon with a client
2. Type SPC w
3. See the bottom line cropped

System Information

https://pastebin.com/w2yJnbHK

[noisycomputation]

This may be a duplicate of #5622.

In any event, there are two workarounds:

• This worked for me, but I no longer use it in favor of
• Adding a line to the which-key window.

The possible crash issue deters me more than advising a which-key function because I might not immediately realize the origin of the crash when it happens, and that could lead to wasted time chasing it down. Upstream changes causing the advice to fail or malfunction ought to be easier to identify.

I'm curious, are you using Wayland? I'm running a pgtk emacs (like you), and this issue only happens in Wayland sessions. When I run emacs in an X11 session, the spacing is perfect without the workaround. This could be useful information for upstream to resolve the issue, because it might have something to do with the limited ability of applications to know things about window positioning in Wayland. (This paragraph is a note for @hlissner, who will know better how to frame it to the which-key folks if the hunch is correct.)

Edit: The hunch was incorrect, disregard note to maintainer.

[TheSirC]

This may be a duplicate of #5622.

It seems to be the same issue indeed ! Weird I could have sworn I searched thoroughly... Thanks !

* [Adding a line to the which-key window](https://github.com/justbur/emacs-which-key/issues/231#issuecomment-627503184).

That's the exact kind of answer I was searching for ! Thanks !

The possible crash issue deters me more than advising a which-key function because I might not immediately realize the origin of the crash when it happens, and that could lead to wasted time chasing it down. Upstream changes causing the advice to fail or malfunction ought to be easier to identify.

I share this analysis and approve of the conclusion !

I'm curious, are you using Wayland?

I am sorry to report that I am not !

(This paragraph is a note for @hlissner, who will know better how to frame it to the which-key folks if the hunch is correct.)

Should close this then ?

[noisycomputation]

Glad I could help.

Should close this then ?

Yes sir, no objections from here.