Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When running in 'donejs start' mode, errors are not shown properly #1190

Open
1 of 5 tasks
hurgleburgler opened this issue Aug 8, 2019 · 0 comments
Open
1 of 5 tasks
Labels

Comments

@hurgleburgler
Copy link

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:
When running in 'donejs start' mode, with 'live-reload' removed from package.json.configDependencies, less errors are not shown on the server's command line. Instead, a generic UnhandledPromiseRejectionWarning: Unhandled promise rejection. is shown.

Steps to reproduce:

  1. Create new donejs app
  2. Remove 'live-reload' from package.json.configDependencies
  3. Force a simple error state:
  • Inside styles.less, add:
html {
  background-color: @blue;
}
  1. Start app with 'donejs develop'
  2. Load app in browser
  3. Note the correct error is shown on the server command line:
    [LessError: variable @blue is undefined]
  4. Restart app with 'donejs start' mode
  5. Load app in browser
  6. Note ambiguous "Warnings" on the command line as the server gobbles up the error messages:
(node:53335) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:53335) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 17)
(node:53335) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 19)

Expected results:
Running in 'donejs start' with 'live-reload' turned off should display actual errors and not hang app.

Running in 'donejs start' with 'live-reload' turned off hangs browser on less errors.

Actual results:

Environment:

Software Version
donejs -V 3.2.0
node -v v11.14.0
npm -v 6.9.0
Browser Chrome
Operating system OSX
@matthewp matthewp added the bug label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants