Removing 'live-reload' from package.json config does not turn off Live Reload

[hurgleburgler]

How often can you reproduce it?

• Always
• Sometimes
• Rarely
• Unable
• I didn’t try

Description:
Removing 'live-reload' from the package.json config and running in 'donejs develop' does not turn off live-reload.

Steps to reproduce:

1. Remove 'live-reload' from configDependencies in package.json
2. Restart app with 'donejs develop'
3. Make a change to index.stache
4. Watch as browser app automagically refreshes

Expected results:

Browser app should not automatically refresh.

Actual results:

Browser app automagically refreshes

Environment:

Software	Version
donejs -V	3.2.0
node -v	v11.14.0
npm -v	6.9.0
Browser	Chrome
Operating system	OSX

[matthewp]

Is this the bug you intended to report? I thought it was about donejs start. The reason that live-reload is not disabled is because --develop always turns on live-reload. So what you want to do is change your package.json scripts "develop" and remove that flag.

[hurgleburgler]

The other issue has been logged. Is the proper way to turn off 'live-reload' to remove it from the configDependencies, or rather to just run the serve command with --no-live-reload?

[hurgleburgler]

Per the documentation on done-serve , at https://github.com/donejs/done-serve#-l---no-live-reload

-l, --no-live-reload
Disable live-reload when used with the --develop option.

Even when I update the package.json 'develop' command with this option, it is still live-reloading.

[matthewp]

I'm going to look into this, that's surprising. I'm not sure why there is both a --no-live-reload and a --develop option, as the primary thing that --develop does is not load a live-reload server.

You can disable it by not passing the --develop flag.