Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaceline doesn't show file name in certain themes? #93

Open
zzantares opened this issue Aug 17, 2018 · 2 comments
Open

Spaceline doesn't show file name in certain themes? #93

zzantares opened this issue Aug 17, 2018 · 2 comments

Comments

@zzantares
Copy link

Hi! I've been using this package for quite some time and it's great, however under certain themes the spaceline doesn't show the name of the file, here's a screenshot, you can see it just draws a black box where the name goes.

screen shot 2018-08-06 at 20 35 42

I experience this effect with the kaolin-themes. I don't think this is an issue, but I wanted to ask what is the face I need to change to fix this? how could I know this myself? Should I discuss this in the kaolin theme's github?

Thanks for any help!

ogdenwebb added a commit to ogdenwebb/emacs-kaolin-themes that referenced this issue Aug 18, 2018
@ogdenwebb
Copy link

I'm not sure that's bug related to my package, but I found a workaround for this issue and push new faces for powerline/spaceline mode-line to master, which should fix the problem. Please test it.

Presumably the problem causes when background in spaceline faces is nil, for example.

(spaceline-highlight-face (:background nil :foreground "#68f3ca"))

Looks like a spaceline segment/separator uses background from the default face as fallback instead of background color from mode-line face in this case.

@zzantares
Copy link
Author

Hi @ogdenwebb, thanks for looking into it! I've pulled the changes but it still doesn't show the filename, now it looks like this:

screen shot 2018-08-18 at 10 58 28

However, if I disable the highlighting option (setq spaceline-all-the-icons-highlight-file-name nil), it does show the filename:

screen shot 2018-08-18 at 11 12 20

Or perhaps, is something wrong in my configuration? Although I have only changed the size, you can see my settings here.

ogdenwebb added a commit to ogdenwebb/spaceline-all-the-icons.el that referenced this issue Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants