Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family name in the some of icons is not handled expectedly in a face object #276

Open
tomoyukim opened this issue Aug 4, 2021 · 0 comments

Comments

@tomoyukim
Copy link

Hello and thank you for your all effort to provide this great package!

I faced an issue that some of the glyphs are not properly displayed when creating a face object with the :family attribute.
For example, the following code returns "icons" unexpectedly. So, the family attribute is not passed to :propertize correctly in mode-line-format.

(defface hoge '((t :family "file-icons")) "")
(face-attribute 'hoge :family) ; => "icons"

This seems to be caused by faces.el implementation. The code treats a string value set in :family attribute as "{foundry}-{family}" format when the value contains a hyphen. So, the family attribute ends up being "icons".
In the case of "all-the-icons", it will be "the".

To avoid this symptom, could you consider changing the family name of some font sets that have a hyphen?
I think the icons listed below should be renamed:

  • all-the-icons
  • file-icons
  • github-octicons

FYI, I use the following version of Emacs. Thank you.
GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95)) of 2020-08-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant