New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-the-icons-XXX-for-mode is not consitently coded #275

Open

bestlem opened this issue Aug 4, 2021 · 1 comment

bestlem commented Aug 4, 2021 •

edited

all-the-icons-icon-for-mode and all-the-icons-family-for-mode do not use the same logic.

I found this on helpful-mode (via issues with spaceline-all-the-icons)

(all-the-icons-icon-family-for-mode 'helpful-mode) ; returns nil
(all-the-icons-icon-for-mode 'helpful-mode) ; Gives an icon

The for mode code deals with the not found icon by looking in the parent mode
ie

(icon (cdr (or (assoc mode all-the-icons-mode-icon-alist)
               (assoc (get mode 'derived-mode-parent) all-the-icons-mode-icon-alist))))

whilst all-the-icons-icon-family-for-mode just does the first assoc

The text was updated successfully, but these errors were encountered:

bestlem mentioned this issue

all-the-icons--icon-info-for-buffer returns wrong icons #145

Closed

Collaborator

wyuenho commented Mar 4, 2022

Feel free to send over a PR

bestlem added a commit to bestlem/emacs.d that referenced this issue


          Deal with missing font amily

428fd9a

cover for bug domtronn/all-the-icons.el#275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment