Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Prolog icon #248

Open
jfmc opened this issue Mar 13, 2021 · 3 comments
Open

Alternative Prolog icon #248

jfmc opened this issue Mar 13, 2021 · 3 comments

Comments

@jfmc
Copy link

jfmc commented Mar 13, 2021

There exists multiple Prolog implementations but the current icon corresponds to the SWI Prolog one (which despite being a great Prolog system is not the only one). Would it be possible to use a more agnostic one? (ideally the current one should be renamed swi-prolog and reserve prolog for the agnostic version.

Together with other implementor, I've prepared an alternative icon (.png exported from the the .svg version):

prolog-icon

@wyuenho
Copy link
Collaborator

wyuenho commented Mar 13, 2021

Theoretically it's possible but currently hard to do as it requires regenerating the icon font from icomoon. Unfortunately the font output from icomoon no longer works and crashes the NS port of Emacs 27. Using SVGs instead is ideal, but currently pending an implementation of #245

@jfmc
Copy link
Author

jfmc commented Mar 14, 2021

Thanks! I tried playing around with this idea and #245 and the package described in that issue. I found that doom-modeline-mode does not work nicely with propertized text including display image attributes (basically it overrides the display property). Either I am doing something wrong or would the SVG approach require major changes in other code using all-the-icons?

@wyuenho
Copy link
Collaborator

wyuenho commented Mar 15, 2021

would the SVG approach require major changes in other code using all-the-icons

There would be some changes required, overriding the display property is definitely a nono, if anybody changes the icon alists now, the format of that list will likely be very different as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants