Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might this repository works for nim v1.6.0 ? #12

Open
dlesnoff opened this issue Jan 10, 2022 · 2 comments
Open

Might this repository works for nim v1.6.0 ? #12

dlesnoff opened this issue Jan 10, 2022 · 2 comments

Comments

@dlesnoff
Copy link

I have not yet fixed the code for Nim 1.6.0 from the book, but if I achieve it, may I propose a Pull Request to make the code functional in v1.6.0 or is this repository discontinued ?
I do not expect to make the code from metaprogramming chapter work (and there are better tutorials for macro in the standard library now).
Chapter3 - ChatClient: In protocol.nim, exceptions directly inherits from Exception but should inherit from a more precise Exception like IOError or ValueError. Apart from this, the client-server works.
Chapter6 - Wikipedia Stats : I believe Wikipedia has changed its API and it does not support pagecount anymore. (I have read the chapter a long time ago so I am not sure).
When I compile, I get that readChars is deprecated.
I had to change .. < into ..< into multiple files but apart from this, it compiles without trouble.
I will test other projects when I will have more time.

@dom96
Copy link
Owner

dom96 commented Jan 18, 2022

Did you test master or the v1.2.6 branch? (see https://github.com/dom96/nim-in-action-code#nim-version-compatibility)

If there are cases where compilation fails in 1.6.0 but not 1.2.6 then a new branch would be great.

@dlesnoff
Copy link
Author

v1.2.6 branch. Some files fails to compile. Exceptions changed.
I may try to remove warnings and hints too, if I have time.
A new branch would be great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants