Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overscrollEnabled={false} not respected when using next and previous buttons #552

Open
stoickeyboard opened this issue Feb 29, 2024 · 1 comment · May be fixed by #555
Open

overscrollEnabled={false} not respected when using next and previous buttons #552

stoickeyboard opened this issue Feb 29, 2024 · 1 comment · May be fixed by #555
Assignees
Labels
bug Something isn't working

Comments

@stoickeyboard
Copy link

Describe the bug

When using previous and next buttons, the carousel scrolls past the last item

and shows extra empty space after the last item even when overscrollEnabled is set to false. This is obviously do to the next and prev scrolling based on the width of the item and not checking if over-scrolling is occurring. overscrollEnabled={false} works as intended when swiping.

Expected behavior
When clicking next the carousel shouldn't scroll past the last item

Screenshots

Kapture.2024-02-28.at.18.41.45.mp4

Versions (please complete the following information):

  • "react": "18.2.0
  • "react-native": "0.73.4",
  • "react-native-reanimated": "~3.6.2"
  • "react-native-reanimated-carousel": "^4.0.0-alpha.9"
  • "react-native-gesture-handler": "~2.14.0"

Smartphone (please complete the following information):

  • Device: Macbook
  • OS: 14.2.1
  • Browser Arc Browser
  • Version 1.31.2

Additional context
I can create a PR for this if pointed in the right direction

@ryanchapel-hero
Copy link

Can we please get this merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants